[Debian-med-packaging] Bug#1066369: obitools: FTBFS: error: implicit declaration of function ‘heapsort’

[Étienne Mollier]

Hi,

Lucas Nussbaum, on 2024-03-13:
> > build/temp.linux-x86_64-cpython-311/pyrex/obitools/word/_readindex.c:6320:3: error: implicit declaration of function ‘heapsort’ [-Werror=implicit-function-declaration]

Interesting, if I trust the Debian online manual of heapsort[1],
this is a Berkeley function optimized for "almost" sorted
arrays.  I see two options here: either try to implement the
libbsd compatibility layer in cython context, or replace
heapsort by qsort[2] (and remove the heapsort function
declaration from the .pyx); the two functions look to have
compatible argument passing.

I would consider implementing the replacement by qsort: this may
affect the memory consumption, and possibly performances of
obitools; on the other hand I wonder how come the program
managed to do the sorting without appropriate function available
in the application binary interface in the first place.

[1]: https://manpages.debian.org/bookworm/libbsd-dev/heapsort.3bsd.en.html
[2]: https://manpages.debian.org/bookworm/manpages-fr-dev/qsort.3.fr.html

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier <emollier at debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/1, please excuse my verbosity
   `-    on air: Genesis - Throwing it All Away
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20240420/eb8571e5/attachment.sig>