[Debian-med-packaging] Bug#1069924: galileo-daemon: switch from dh-sysuser to standard dh_installsysusers

[Helmut Grohne]

Package: galileo-daemon
Version: 0.5.1-9.1
Severity: wishlist
Tags: patch

Hi,

dh-sysusers exists since about 7 years and has gotten 9 users in that
time - galileo-daemon being one of them. It still has a number of
deficiencies such as using useradd instead of policy-recommended adduser
or removing users on package removal against project consensus. I think
it is time to call this a failed experiment and move to the declarative
sysusers.d mechanism used by many more packages which also is available
in multiple implementations now such that it can be used with
non-systemd systems. Do you agree with the reasoning? I'm attaching a
patch for your convenience.

Helmut
-------------- next part --------------
diff --minimal -Nru galileo-0.5.1/debian/changelog galileo-0.5.1/debian/changelog
--- galileo-0.5.1/debian/changelog	2022-10-15 12:06:41.000000000 +0200
+++ galileo-0.5.1/debian/changelog	2024-04-27 09:49:06.000000000 +0200
@@ -1,3 +1,10 @@
+galileo (0.5.1-9.2) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Switch from dh-sysuser to standard dh_installsysusers (Closes: #-1)
+
+ -- Helmut Grohne <helmut at subdivi.de>  Sat, 27 Apr 2024 09:49:06 +0200
+
 galileo (0.5.1-9.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff --minimal -Nru galileo-0.5.1/debian/control galileo-0.5.1/debian/control
--- galileo-0.5.1/debian/control	2022-04-09 22:36:10.000000000 +0200
+++ galileo-0.5.1/debian/control	2024-04-27 09:48:23.000000000 +0200
@@ -3,9 +3,9 @@
 Uploaders: Dylan A?ssi <daissi at debian.org>
 Section: science
 Priority: optional
-Build-Depends: debhelper-compat (= 13),
+Build-Depends: debhelper (>= 13.3),
+               debhelper-compat (= 13),
                dh-sequence-python3,
-               dh-sysuser,
                python3,
                python3-requests,
                python3-setuptools,
diff --minimal -Nru galileo-0.5.1/debian/galileo-daemon.sysusers galileo-0.5.1/debian/galileo-daemon.sysusers
--- galileo-0.5.1/debian/galileo-daemon.sysusers	1970-01-01 01:00:00.000000000 +0100
+++ galileo-0.5.1/debian/galileo-daemon.sysusers	2024-04-27 09:49:06.000000000 +0200
@@ -0,0 +1 @@
+u	galileo	-	"system user for galileo-daemon"	/nonexistent	/usr/sbin/nologin
diff --minimal -Nru galileo-0.5.1/debian/rules galileo-0.5.1/debian/rules
--- galileo-0.5.1/debian/rules	2022-04-09 22:36:10.000000000 +0200
+++ galileo-0.5.1/debian/rules	2024-04-27 09:47:11.000000000 +0200
@@ -5,10 +5,7 @@
 export PYBUILD_DESTDIR_python3=debian/galileo/
 
 %:
-	dh $@ --with sysuser --buildsystem=pybuild
-
-override_dh_sysuser:
-	dh_sysuser -pgalileo-daemon galileo
+	dh $@ --buildsystem=pybuild
 
 override_dh_installudev:
 	dh_installudev -pgalileo --priority=98
@@ -16,3 +13,5 @@
 
 override_dh_installinit:
 	dh_installinit --noscripts
+       # Can be dropped in compat >= 14:
+	dh_installsysusers