[Debian-med-packaging] Bug#1078982: uncalled: FTBFS against HDF5 1.14 - Needs -DH5_USE_110_API

[Gilles Filippini]

Source: uncalled
Version: 2.3+ds-1
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

The uncalled package fails to build from source in a test rebuild
against hdf5 1.14 currently in experimental:

x86_64-linux-gnu-gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O2 -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection 
- -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DPYBIND -I./submods -I/usr/include/hdf5/serial -I/usr/include/fast5/ -I/usr/include/ -I/usr/lib/python3/dist-packages/pybin
d11/include -I/usr/include/python3.12 -c src/chunk.cpp -o build/temp.linux-x86_64-cpython-312/src/chunk.o -std=c++11 -O3
cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++
In file included from src/read_buffer.hpp:30,
                 from src/chunk.cpp:3:
/usr/include/fast5/hdf5_tools.hpp: In member function ‘std::vector<std::__cxx11::basic_string<char> > hdf5_tools::File::get_attr_list(const std::string&) const’:
/usr/include/fast5/hdf5_tools.hpp:2110:27: error: no matching function for call to ‘hdf5_tools::detail::Util::wrap(herr_t (&)(hid_t, H5O_info2_t*, unsigned int), hid_t&, H5O_info2_t*) const’
 2110 |         detail::Util::wrap(H5Oget_info, id_holder.id, &info);
      |         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/fast5/hdf5_tools.hpp:244:5: note: candidate: ‘template<class Function, class ... Args> static typename std::result_of<_Functor(_ArgTypes ...)>::type hdf5_tools::detail::Util::wrap(Function&&, Args&& ...)’
  244 |     wrap(Function && f, Args && ...args)
      |     ^~~~
/usr/include/fast5/hdf5_tools.hpp:244:5: note:   template argument deduction/substitution failed:
/usr/include/fast5/hdf5_tools.hpp: In substitution of ‘template<class Function, class ... Args> static typename std::result_of<_Functor(_ArgTypes ...)>::type hdf5_tools::detail::Util::wrap(Function&&, Args&& ...) [with Function = int (&)(long int, H5O_info2_t*, unsigned int); Args = {long int&, H5O_info2_t*}]’:
/usr/include/fast5/hdf5_tools.hpp:2110:27:   required from here
 2110 |         detail::Util::wrap(H5Oget_info, id_holder.id, &info);
      |         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/fast5/hdf5_tools.hpp:244:5: error: no type named ‘type’ in ‘struct std::result_of<int (&(long int&, H5O_info2_t*))(long int, H5O_info2_t*, unsigned int)>’
  244 |     wrap(Function && f, Args && ...args)
      |     ^~~~


Adding -DH5_USE_110_API to CPPFLAGS solves the issue.

Please note that the same fix should be applied to fast5 first (#1078976).

Best,
_g.

- -- System Information:
Debian Release: 12.0
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-21-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAmbCCaIACgkQ7+hsbH/+
z4OEMgf/aiZGwhZyzy7wC7OJYykTVP7YxuuyFPeSmZiNyHyMRZi/8Oar8V8ZOnuA
5OfEVO724IcvZ7lRmp7GI4qhRuYebOQFROPCmecJqt5Uck9jNRRBFJ4PtJEWXwJ0
z98/l+kn4rPDENXvEVavNUyvnSzy3Wh/qAIuYYN/35suM6ai/zc4GefSNoFmpKL2
ZXK7UuGtwcNiTdIaPyk2p/t2A1B0VNrACasoOxv9MwvdNxf4DPPDq/Cbxg93IKb2
uAYhmAiKdVcGfzxu5Vw9DsIbutpaf1aVua9tvWiFjetKry8NmOK9dWDEtIAYvRiD
4i1tAxg77BNQYaeIfpcybNTHVCp11w==
=hlt6
-----END PGP SIGNATURE-----