[Debian-med-packaging] Bug#1089095: python-pbcore: please make the build reproducible

[Chris Lamb]

Source: python-pbcore
Version: 2.1.2+dfsg-9
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
python-pbcore could not be built reproducibly.

Like #1088353 and #1088742, this was because the call to remove the
offending files (within execute_after_dh_python3 for some reason) did
not take into account different Python installation target directories.

In general, using the PYBUILD_* things will tend to provide more
robustness and future-proofing against similar changes, if only
because of the magical interpolation of {build_dir}.

Patch attached. It might be worth doing a quick grep over your other
packages to see if there are other easily remediable instances of
this.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2024-12-05 10:47:40.350985901 +0000
--- b/debian/rules	2024-12-05 11:09:56.741988581 +0000
@@ -6,6 +6,7 @@
 export PYBUILD_NAME = pbcore
 export PYBUILD_AFTER_INSTALL = \
   chmod -x {destdir}/{install_dir}/pbcore/data/datasets/*.xml
+export PYBUILD_AFTER_TEST = rm -rfv {build_dir}/coverage.xml {build_dir}/nosetests.xml
 DESTDIR = $(CURDIR)/debian/python3-$(PYBUILD_NAME)
 DOCDIR = $(CURDIR)/debian/python-pbcore-doc
 export LC_ALL=C.UTF-8
@@ -21,10 +22,6 @@
 	mv $(DESTDIR)/usr/bin/.open $(DESTDIR)/usr/bin/pbopen
 	rmdir $(DOCDIR)/usr/share/doc/python3-pbcore/html/_images/
 
-execute_after_dh_python3:
-	rm -vf $(DESTDIR)/usr/lib/python3/dist-packages/coverage.xml
-	rm -vf $(DESTDIR)/usr/lib/python3/dist-packages/nosetests.xml
-
 override_dh_installdocs:
 	dh_installdocs -X _source