[Debian-med-packaging] Bug#1090768: dipy: Skipping long tests is broken

Colin Watson cjwatson at debian.org
Thu Dec 19 00:56:31 GMT 2024


Source: dipy
Version: 1.10.0-1
Severity: important
Tags: patch

https://ci.debian.net/packages/d/dipy/testing/i386/55539119/ shows that
the code in debian/rules that's supposed to skip long tests doesn't
actually work.  On investigation I found that pytest only seems to
include the basename of the test file (and of at least some other
containing directories, I think) in the keywords that you can select or
deselect using -k.  Fortunately, the basenames of the tests that you
want to exclude here are all unique.

diff --git a/debian/rules b/debian/rules
index 3f380dab..a30d40e4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -26,11 +26,9 @@ BUILD_DATE := $(shell \
 )
 SPHINXOPTS := -D today=\"$(BUILD_DATE)\"
 
-# WARNING: test specifications below should match d/t/run-unit-test!
-
 # These tests attempt to make use of the network, notably during setup phase.
 SKIP_NET_TESTS := \
-	not dipy/utils/tests/test_tractogram.py \
+	not test_tractogram.py \
 	and not test_io_info \
 	and not test_concatenate_flow \
 	and not test_convert_tractogram_flow \
@@ -43,11 +41,11 @@ SKIP_NET_TESTS := \
 # These tests hog resources because they are too long, so it is preferable to
 # skip them to give the infrastructure some breath.
 SKIP_LONG_TESTS := \
-	not dipy/align/tests/test_streamwarp.py \
-	and not dipy/denoise/tests/test_lpca.py \
-	and not dipy/reconst/tests/test_sfm.py \
-	and not dipy/workflows/tests/test_reconst_csa_csd.py \
-	and not dipy/workflows/tests/test_reconst_rumba.py
+	not test_streamwarp.py \
+	and not test_lpca.py \
+	and not test_sfm.py \
+	and not test_reconst_csa_csd.py \
+	and not test_reconst_rumba.py
 
 SKIP_32BIT_TESTS := not test_check_img_shapes
 

Thanks,

-- 
Colin Watson (he/him)                              [cjwatson at debian.org]



More information about the Debian-med-packaging mailing list