[Debian-med-packaging] Bug#1091265: minc-tools: FTBFS on armhf: mnc2nii.c:743:23: error: passing argument 3 of ‘restructure_array’ from incompatible pointer type [-Wincompatible-pointer-types]

[Lucas Nussbaum]

Source: minc-tools
Version: 2.3.00+dfsg-10
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20241223 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, this package failed to build
on armhf.

This package currently has binary packages on armhf, so this is a regression.
Also, there are no known issues on amd64 or arm64 according to recent (a couple
days ago) rebuilds.

The rebuild was done using an armhf chroot on an AWS "m6g" instance (Graviton2
CPU).

Relevant part (hopefully):
> cd /<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf/conversion && /usr/bin/cc -DHAVE_CONFIG_H -DHAVE_MINC1=1 -DHAVE_MINC2=1 -DMINC2=1 -I/usr/lib/arm-linux-gnueabihf/include -I/<<PKGBUILDDIR>>/obj-arm-linux-gnueabihf -I/<<PKGBUILDDIR>>/conversion/Acr_nema -I/usr/include/nifti -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/hdf5/serial -MD -MT conversion/CMakeFiles/mnc2nii.dir/nifti1/mnc2nii.c.o -MF CMakeFiles/mnc2nii.dir/nifti1/mnc2nii.c.o.d -o CMakeFiles/mnc2nii.dir/nifti1/mnc2nii.c.o -c /<<PKGBUILDDIR>>/conversion/nifti1/mnc2nii.c
> /<<PKGBUILDDIR>>/conversion/nifti1/mnc2nii.c: In function ‘main’:
> /<<PKGBUILDDIR>>/conversion/nifti1/mnc2nii.c:736:31: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=]
>   736 |         printf("# of voxels %ld\n", nii_ptr->nvox);
>       |                             ~~^     ~~~~~~~~~~~~~
>       |                               |            |
>       |                               long int     size_t {aka unsigned int}
>       |                             %d
> /<<PKGBUILDDIR>>/conversion/nifti1/mnc2nii.c:743:23: error: passing argument 3 of ‘restructure_array’ from incompatible pointer type [-Wincompatible-pointer-types]
>   743 |                       nii_lens,
>       |                       ^~~~~~~~
>       |                       |
>       |                       long unsigned int *
> In file included from /<<PKGBUILDDIR>>/conversion/nifti1/mnc2nii.c:8:
> /usr/include/restructure.h:13:37: note: expected ‘const size_t *’ {aka ‘const unsigned int *’} but argument is of type ‘long unsigned int *’
>    13 |                       const size_t *lengths_perm,
>       |                       ~~~~~~~~~~~~~~^~~~~~~~~~~~
> make[3]: *** [conversion/CMakeFiles/mnc2nii.dir/build.make:82: conversion/CMakeFiles/mnc2nii.dir/nifti1/mnc2nii.c.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/12/23/minc-tools_2.3.00+dfsg-10_unstable-armhf.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20241223;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20241223&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.