[Debian-med-packaging] Bug#1062757: odil: NMU diff for 64-bit time_t transition

[Lucas Kanashiro]

Source: odil
Version: 0.12.2-4
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-arm at lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
odil as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for odil
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.2.0-39-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru odil-0.12.2/debian/changelog odil-0.12.2/debian/changelog
--- odil-0.12.2/debian/changelog	2023-12-21 16:12:20.000000000 -0300
+++ odil-0.12.2/debian/changelog	2024-02-02 16:41:40.000000000 -0300
@@ -1,3 +1,10 @@
+odil (0.12.2-4.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Lucas <kanashiro at ubuntu.com>  Fri, 02 Feb 2024 16:41:40 -0300
+
 odil (0.12.2-4) unstable; urgency=medium
 
   * Team upload.
diff -Nru odil-0.12.2/debian/control odil-0.12.2/debian/control
--- odil-0.12.2/debian/control	2023-12-21 16:12:20.000000000 -0300
+++ odil-0.12.2/debian/control	2024-02-02 16:41:40.000000000 -0300
@@ -5,7 +5,7 @@
 Testsuite: autopkgtest-pkg-python
 Priority: optional
 Build-Depends: debhelper-compat (= 13),
-               d-shlibs,
+               d-shlibs (>= 0.106),
                dh-python,
                cmake,
                pkg-config,
@@ -34,15 +34,15 @@
 Homepage: https://github.com/lamyj/odil
 Rules-Requires-Root: no
 
-Package: libodil0
+Package: libodil0t64
 Architecture: amd64 arm64 armel armhf i386 loong64 mipsel ppc64el s390x alpha ia64 powerpc ppc64 riscv64 x32
 Multi-Arch: same
 Section: libs
 Depends: ${shlibs:Depends},
          ${misc:Depends}
-Conflicts: libdcmtkpp0
-Provides: libdcmtkpp0
-Replaces: libdcmtkpp0
+Conflicts: libodil0 (<< ${source:Version}), libdcmtkpp0 
+Provides: ${t64:Provides}, libdcmtkpp0
+Replaces: libodil0, libdcmtkpp0
 Description: C++11 library for the DICOM standard
  Odil leverages C++ constructs to provide a user-friendly API of the
  different parts of the DICOM standard. Included in Odil are exception-based
@@ -58,7 +58,7 @@
 Architecture: amd64 arm64 armel armhf i386 loong64 mipsel ppc64el s390x
 Multi-Arch: same
 Section: libdevel
-Depends: libodil0 (= ${binary:Version}),
+Depends: libodil0t64 (= ${binary:Version}),
          ${devlibs:Depends},
          ${misc:Depends}
 Conflicts: libdcmtkpp-dev
@@ -97,7 +97,7 @@
 Architecture: amd64 arm64 armel armhf i386 loong64 mipsel ppc64el s390x
 Multi-Arch: foreign
 Section: python
-Depends: libodil0 (= ${binary:Version}),
+Depends: libodil0t64 (= ${binary:Version}),
          ${shlibs:Depends},
          ${python3:Depends},
          ${misc:Depends}
diff -Nru odil-0.12.2/debian/libodil0t64.lintian-overrides odil-0.12.2/debian/libodil0t64.lintian-overrides
--- odil-0.12.2/debian/libodil0t64.lintian-overrides	1969-12-31 21:00:00.000000000 -0300
+++ odil-0.12.2/debian/libodil0t64.lintian-overrides	2024-02-02 16:41:40.000000000 -0300
@@ -0,0 +1 @@
+libodil0t64: package-name-doesnt-match-sonames libodil0
diff -Nru odil-0.12.2/debian/rules odil-0.12.2/debian/rules
--- odil-0.12.2/debian/rules	2023-12-21 16:12:20.000000000 -0300
+++ odil-0.12.2/debian/rules	2024-02-02 16:41:40.000000000 -0300
@@ -102,6 +102,7 @@
 override_dh_install-arch:
 	dh_install
 	d-shlibmove \
+		--t64 \
 		--devunversioned \
 		--commit --multiarch --exclude-a --exclude-la \
 		--movedev debian/tmp/usr/include/* usr/include \