[Debian-med-packaging] Bug#1063178: nifticlib: NMU diff for 64-bit time_t transition

[Steve Langasek]

Source: nifticlib
Version: 3.0.1-9
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-arm at lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
nifticlib as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for nifticlib
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru nifticlib-3.0.1/debian/changelog nifticlib-3.0.1/debian/changelog
--- nifticlib-3.0.1/debian/changelog	2022-05-31 16:28:14.000000000 +0000
+++ nifticlib-3.0.1/debian/changelog	2024-02-05 08:48:08.000000000 +0000
@@ -1,3 +1,11 @@
+nifticlib (3.0.1-9.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+  * Bump build-dependency on d-shlibs for --t64 support.
+
+ -- Steve Langasek <vorlon at debian.org>  Mon, 05 Feb 2024 08:48:08 +0000
+
 nifticlib (3.0.1-9) unstable; urgency=medium
 
   * Team upload.
diff -Nru nifticlib-3.0.1/debian/control nifticlib-3.0.1/debian/control
--- nifticlib-3.0.1/debian/control	2022-05-31 16:24:31.000000000 +0000
+++ nifticlib-3.0.1/debian/control	2024-02-05 08:48:08.000000000 +0000
@@ -5,7 +5,7 @@
 Section: science
 Priority: optional
 Build-Depends: debhelper-compat (= 13),
-               d-shlibs,
+               d-shlibs (>= 0.106),
                cmake,
                zlib1g-dev,
                doxygen,
@@ -64,14 +64,15 @@
  This is a transitional dummy package.  It installs libnifti2-dev which
  should be used instead.
 
-Package: libniftiio2
+Package: libniftiio2t64
+Provides: ${t64:Provides}
 Architecture: any
 Multi-Arch: same
 Section: libs
 Depends: ${shlibs:Depends},
          ${misc:Depends}
-Breaks: libnifti2 (<= 3.0)
-Replaces: libnifti2 (<= 3.0)
+Conflicts: libniftiio2 (<< ${source:Version}), libnifti2 (<= 3.0)
+Replaces: libniftiio2, libnifti2 (<= 3.0)
 Description: low-level IO libraries for the NIfTI-1 data format (niftiio)
  Niftilib is a set of i/o libraries for reading and writing files in the
  NIfTI-1 data format. NIfTI-1 is a binary file format for storing medical
@@ -84,7 +85,7 @@
 Architecture: any
 Multi-Arch: same
 Section: libdevel
-Depends: libniftiio2 (= ${binary:Version}),
+Depends: libniftiio2t64 (= ${binary:Version}),
          ${misc:Depends}
 Breaks: libnifti-dev (<= 3.0)
 Replaces: libnifti-dev (<= 3.0)
diff -Nru nifticlib-3.0.1/debian/libniftiio2t64.lintian-overrides nifticlib-3.0.1/debian/libniftiio2t64.lintian-overrides
--- nifticlib-3.0.1/debian/libniftiio2t64.lintian-overrides	1970-01-01 00:00:00.000000000 +0000
+++ nifticlib-3.0.1/debian/libniftiio2t64.lintian-overrides	2024-02-05 08:48:07.000000000 +0000
@@ -0,0 +1 @@
+libniftiio2t64: package-name-doesnt-match-sonames libniftiio2
diff -Nru nifticlib-3.0.1/debian/rules nifticlib-3.0.1/debian/rules
--- nifticlib-3.0.1/debian/rules	2022-05-30 16:03:11.000000000 +0000
+++ nifticlib-3.0.1/debian/rules	2024-02-05 08:48:08.000000000 +0000
@@ -83,6 +83,7 @@
 		    --movedev debian/libnifti2-dev/usr/include/nifti/znzlib.h usr/include/nifti \
 		    debian/tmp/usr/lib/libznz*.so
 	d-shlibmove --commit \
+		    --t64 \
 		    --multiarch \
 		    --devunversioned \
 		    --exclude-la \