[Debian-med-packaging] Bug#1074900: daligner: ftbfs with GCC-14

[Matthias Klose]

Package: src:daligner
Version: 1.0+git20240119.335105d-2
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/daligner_1.0+git20240119.335105d-2_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
   37 | #define assert(x) 0
      |                   ^
ONElib.c:2033:3: note: in expansion of macro ‘assert’
 2033 |   assert (li) ;
      |   ^~~~~~
ONElib.c:37:19: warning: statement with no effect [-Wunused-value]
   37 | #define assert(x) 0
      |                   ^
ONElib.c:2040:7: note: in expansion of macro ‘assert’
 2040 |     { assert (listLen >= 0) ;
      |       ^~~~~~
ONElib.c: In function ‘oneFileClose’:
ONElib.c:37:19: warning: statement with no effect [-Wunused-value]
   37 | #define assert(x) 0
      |                   ^
ONElib.c:2488:3: note: in expansion of macro ‘assert’
 2488 |   assert (vf->share >= 0) ;
      |   ^~~~~~
ONElib.c: In function ‘intGet’:
ONElib.c:3490:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
 3490 |         case 0: die ("int packing error") ;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
ONElib.c:3491:9: note: here
 3491 |         case 1: *pval = *(I64*)(u+1) & 0x0000000000ffff ; return 3 ;
      |         ^~~~
ONElib.c:3502:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
 3502 |         case 0: die ("int packing error") ;
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
ONElib.c:3503:9: note: here
 3503 |         case 1: *pval = *(I64*)(u+1) | 0xffffffffffff0000 ; return 3 ;
      |         ^~~~
ONElib.c:3488:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
 3488 |       switch (u[0] & 0x07)
      |       ^~~~~~
ONElib.c:3499:5: note: here
 3499 |     case 4:
      |     ^~~~
ONElib.c: In function ‘ltfRead’:
ONElib.c:3564:10: warning: ‘val’ may be used uninitialized [-Wmaybe-uninitialized]
 3564 |   return val ;
      |          ^~~
ONElib.c:3544:7: note: ‘val’ was declared here
 3544 |   I64 val ;
      |       ^~~
ONElib.c: In function ‘oneFileOpenWriteFrom’:
ONElib.c:395:33: warning: ‘%ld’ directive writing between 1 and 19 bytes into a region of size between 7 and 25 [-Wformat-overflow=]
  395 |     sprintf (text, "P %ld %s\nS %ld %s\n", strlen(fileType),fileType, strlen(subType), subType) ;
      |                                 ^~~
In function ‘oneSchemaCreateDynamic’,
    inlined from ‘oneFileOpenWriteFrom’ at ONElib.c:1657:20:
ONElib.c:395:20: note: directive argument in the range [0, 9223372036854775805]
  395 |     sprintf (text, "P %ld %s\nS %ld %s\n", strlen(fileType),fileType, strlen(subType), subType) ;
      |                    ^~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/stdio.h:964,
                 from ONElib.c:22:
In function ‘sprintf’,
    inlined from ‘oneSchemaCreateDynamic’ at ONElib.c:395:5,
    inlined from ‘oneFileOpenWriteFrom’ at ONElib.c:1657:20:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output 11 or more bytes (assuming 47) into a destination of size 32
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:40: ONE2LA] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:9: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2