[Debian-med-packaging] Bug#1075203: libsis-jhdf5-java: ftbfs with GCC-14

[Matthias Klose]

Package: src:libsis-jhdf5-java
Version: 19.04.1+dfsg-4
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/libsis-jhdf5-java_19.04.1+dfsg-4_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
jni/h5dImp.c:1378:37: warning: passing argument 1 of ‘h5str_vlconvert’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1378 |                     h5str_vlconvert(utf8, did, tid, wdata+i, 0);
      |                                     ^~~~
In file included from jni/h5dImp.c:29:
jni/h5util.h:44:38: note: expected ‘char *’ but argument is of type ‘const char *’
   44 | extern size_t  h5str_vlconvert(char *str, hid_t container, hid_t tid, hvl_t *ptr, int expand_data);
      |                                ~~~~~~^~~
jni/h5pImp.c: In function ‘Java_hdf_hdf5lib_H5_H5Pget_1chunk_1opts’:
jni/h5pImp.c:5933:43: error: passing argument 2 of ‘H5Pget_chunk_opts’ makes pointer from integer without a cast [-Wint-conversion]
 5933 |     if (H5Pget_chunk_opts((hid_t)dcpl_id, opts) < 0)
      |                                           ^~~~
      |                                           |
      |                                           unsigned int
In file included from /usr/include/hdf5/serial/hdf5.h:33,
                 from jni/h5pImp.c:25:
/usr/include/hdf5/serial/H5Ppublic.h:5472:59: note: expected ‘unsigned int *’ but argument is of type ‘unsigned int’
 5472 | H5_DLL herr_t H5Pget_chunk_opts(hid_t plist_id, unsigned *opts);
      |                                                 ~~~~~~~~~~^~~~
jni/h5util.c: In function ‘h5str_convert’:
jni/h5util.c:336:27: warning: too many arguments for format [-Wformat-extra-args]
  336 |             sscanf(token, "%%lf", &tmp_double);
      |                           ^~~~~~
jni/h5util.c:364:34: warning: format ‘%hu’ expects argument of type ‘short unsigned int *’, but argument 3 has type ‘unsigned char *’ [-Wformat=]
  364 |                 sscanf(token, "%hu", &tmp_uchar);
      |                                ~~^   ~~~~~~~~~~
      |                                  |   |
      |                                  |   unsigned char *
      |                                  short unsigned int *
      |                                %hhu
jni/h5util.c:370:34: warning: format ‘%hd’ expects argument of type ‘short int *’, but argument 3 has type ‘char *’ [-Wformat=]
  370 |                 sscanf(token, "%hd", &tmp_char);
      |                                ~~^   ~~~~~~~~~
      |                                  |   |
      |                                  |   char *
      |                                  short int *
      |                                %hhd
jni/h5util.c:392:33: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘short unsigned int *’ [-Wformat=]
  392 |                 sscanf(token, "%u", &tmp_ushort);
      |                                ~^   ~~~~~~~~~~~
      |                                 |   |
      |                                 |   short unsigned int *
      |                                 unsigned int *
      |                                %hu
jni/h5util.c:398:33: warning: format ‘%d’ expects argument of type ‘int *’, but argument 3 has type ‘short int *’ [-Wformat=]
  398 |                 sscanf(token, "%d", &tmp_short);
      |                                ~^   ~~~~~~~~~~
      |                                 |   |
      |                                 |   short int *
      |                                 int *
      |                                %hd
jni/h5util.c:514:54: error: passing argument 4 of ‘h5str_convert’ from incompatible pointer type [-Wincompatible-pointer-types]
  514 |             h5str_convert(str, container, mtid, cptr + (i*offset), offset, expand_data);
      |                                                 ~~~~~^~~~~~~~~~~~
      |                                                      |
      |                                                      char *
jni/h5util.c:281:53: note: expected ‘hvl_t *’ but argument is of type ‘char *’
  281 |     (char **str, hid_t container, hid_t tid, hvl_t *ptr, int ptroffset, int expand_data)
      |                                              ~~~~~~~^~~
jni/h5util.c:542:58: error: passing argument 4 of ‘h5str_convert’ from incompatible pointer type [-Wincompatible-pointer-types]
  542 |                 h5str_convert(str, container, mtid, cptr + (i*offset), offset, expand_data);
      |                                                     ~~~~~^~~~~~~~~~~~
      |                                                          |
      |                                                          char *
jni/h5util.c:281:53: note: expected ‘hvl_t *’ but argument is of type ‘char *’
  281 |     (char **str, hid_t container, hid_t tid, hvl_t *ptr, int ptroffset, int expand_data)
      |                                              ~~~~~~~^~~
make[1]: *** [debian/rules:33: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:17: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2