[Debian-med-packaging] Bug#1075241: lucy: ftbfs with GCC-14

[Matthias Klose]

Package: src:lucy
Version: 1.20-4
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/lucy_1.20-4_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
qual_trim.c:706:16: warning: unused variable ‘err’ [-Wunused-variable]
  706 |         double err, sum;
      |                ^~~
qual_trim.c: At top level:
qual_trim.c:793:1: warning: "/*" within comment [-Wcomment]
  793 | /* Sets up 3 windows for quality trimming, with the average error allowed
qual_trim.c:794:1: warning: "/*" within comment [-Wcomment]
  794 | /* in each window calculated from max_avg_error.
qual_trim.c:795:1: warning: "/*" within comment [-Wcomment]
  795 | /*
qual_trim.c:796:1: warning: "/*" within comment [-Wcomment]
  796 | /* Globals used:
qual_trim.c:797:1: warning: "/*" within comment [-Wcomment]
  797 | /*      int num_windows,        (number of windows)
qual_trim.c:798:1: warning: "/*" within comment [-Wcomment]
  798 | /*      int *windows,           (array of window sizes (largest to smallest))
qual_trim.c:799:1: warning: "/*" within comment [-Wcomment]
  799 | /*      double *err_limits,     (array of maximum allowed average probability)
qual_trim.c:800:1: warning: "/*" within comment [-Wcomment]
  800 | /*                              (for each window size)
qual_trim.c:801:1: warning: "/*" within comment [-Wcomment]
  801 | /*      double max_avg_error,   (maximum allowed average probability of error)
lucy.c: In function ‘main’:
qual_trim.c:802:1: warning: "/*" within comment [-Wcomment]
  802 | /*
qual_trim.c:827:1: warning: "/*" within comment [-Wcomment]
  827 | /* Simulates the functionality of the old grim() function, by calling
qual_trim.c:828:1: warning: "/*" within comment [-Wcomment]
  828 | /* quality_trim().
qual_trim.c:829:1: warning: "/*" within comment [-Wcomment]
  829 | /*
lucy.c:532:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  532 |     if (pthread_create(&threads[i], NULL, worker, (void*)i))
      |                                                   ^
qual_trim.c:830:1: warning: "/*" within comment [-Wcomment]
  830 | /* Globals used:
qual_trim.c:831:1: warning: "/*" within comment [-Wcomment]
  831 | /*      int num_windows,        (number of windows)
qual_trim.c:832:1: warning: "/*" within comment [-Wcomment]
  832 | /*      int *windows,           (array of window sizes (largest to smallest))
qual_trim.c:833:1: warning: "/*" within comment [-Wcomment]
  833 | /*      double *err_limits,     (array of maximum allowed average probability)
qual_trim.c:834:1: warning: "/*" within comment [-Wcomment]
  834 | /*                              (for each window size)
qual_trim.c:835:1: warning: "/*" within comment [-Wcomment]
  835 | /*      double max_avg_error,   (maximum allowed average probability of error)
qual_trim.c:836:1: warning: "/*" within comment [-Wcomment]
  836 | /*      double end_limit,       (maximum allowed probability of error for bases)
qual_trim.c:837:1: warning: "/*" within comment [-Wcomment]
  837 | /*                              (  at each end of clean range)
qual_trim.c:838:1: warning: "/*" within comment [-Wcomment]
  838 | /*
lucy.c:793:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  793 |            (i=(int)fgets(buf, BUFFER_LENGTH, spl_file)) && buf[0]!='>'; ) {
      |               ^
vector.c: In function ‘tag_code’:
vector.c:45:10: warning: ‘tmp’ may be used uninitialized [-Wmaybe-uninitialized]
   45 |   return tmp;
      |          ^~~
vector.c:23:16: note: ‘tmp’ was declared here
   23 |   register int tmp;
      |                ^~~
lucy.c:632:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  632 |       fgets(buf, BUFFER_LENGTH, qul_file);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [<builtin>: lucy.o] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:9: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2