[Debian-med-packaging] Bug#1075571: thesias: ftbfs with GCC-14

[Matthias Klose]

Package: src:thesias
Version: 3.1.1-2
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/thesias_3.1.1-2_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
             ^
java/OptionDialog.java:373: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            {new Integer(2),"V6"},
             ^
java/OptionDialog.java:374: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            {new Integer(3),""},
             ^
java/OptionDialog.java:375: warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
            {new Integer(4),""},
             ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
17 warnings
jar cfe thesias.jar GraficT -C class . -C misc LogoThesias.png
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
src/newthesias3d.c: In function ‘fishnull’:
src/newthesias3d.c:795:19: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
  795 |  deriv=(double *) malloc((size_t) (dimf*sizeof(double)));
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/newthesias3d.c:25:
/usr/include/stdlib.h:672:14: note: in a call to allocation function ‘malloc’ declared here
  672 | extern void *malloc (size_t __size) __THROW __attribute_malloc__
      |              ^~~~~~
src/newthesias3d.c:795:19: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
  795 |  deriv=(double *) malloc((size_t) (dimf*sizeof(double)));
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdlib.h:672:14: note: in a call to allocation function ‘malloc’ declared here
  672 | extern void *malloc (size_t __size) __THROW __attribute_malloc__
      |              ^~~~~~
src/newthesias3d.c: In function ‘Xfishnull’:
src/newthesias3d.c:861:19: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
  861 |  deriv=(double *) malloc((size_t) (dimf*sizeof(double)));
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdlib.h:672:14: note: in a call to allocation function ‘malloc’ declared here
  672 | extern void *malloc (size_t __size) __THROW __attribute_malloc__
      |              ^~~~~~
src/newthesias3d.c:861:19: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
  861 |  deriv=(double *) malloc((size_t) (dimf*sizeof(double)));
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/stdlib.h:672:14: note: in a call to allocation function ‘malloc’ declared here
  672 | extern void *malloc (size_t __size) __THROW __attribute_malloc__
      |              ^~~~~~
src/thesiaslib.c: In function ‘Java_thesiaslib_thesiasRun’:
src/thesiaslib.c:58:24: warning: passing argument 1 of ‘thesiasRun’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   58 |         i = thesiasRun(cFileName,
      |                        ^~~~~~~~~
src/thesiaslib.c:29:23: note: expected ‘char *’ but argument is of type ‘const char *’
   29 | extern int thesiasRun(char*, int, int, int, int, int, int, int, int, int, int, int, int, int, int, int);
      |                       ^~~~~
src/thesiaslib.c:61:24: error: passing argument 4 of ‘thesiasRun’ makes integer from pointer without a cast [-Wint-conversion]
   61 |                        aNdloci,
      |                        ^~~~~~~
      |                        |
      |                        jint * {aka int *}
src/thesiaslib.c:29:40: note: expected ‘int’ but argument is of type ‘jint *’ {aka ‘int *’}
   29 | extern int thesiasRun(char*, int, int, int, int, int, int, int, int, int, int, int, int, int, int, int);
      |                                        ^~~
src/thesiaslib.c:71:24: error: passing argument 14 of ‘thesiasRun’ makes integer from pointer without a cast [-Wint-conversion]
   71 |                        aNumajust,
      |                        ^~~~~~~~~
      |                        |
      |                        jint * {aka int *}
src/thesiaslib.c:29:90: note: expected ‘int’ but argument is of type ‘jint *’ {aka ‘int *’}
   29 | extern int thesiasRun(char*, int, int, int, int, int, int, int, int, int, int, int, int, int, int, int);
      |                                                                                          ^~~
make[1]: *** [Makefile:34: libthesiaslib.so] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2