[Debian-med-packaging] Bug#1075607: unifrac: autogenerated C code ftbfs with GCC-14

[Étienne Mollier]

Control: tags -1 + confirmed

Hi,

The relevant part of the build log would be:

	unifrac/_api.c:27151:32:
	error: assignment to ‘_Bool *’
	       from incompatible pointer type ‘__pyx_t_7unifrac_4_api_bool *’
	       {aka ‘unsigned char *’}
	       [-Wincompatible-pointer-types]
	27151 |   __pyx_v_sp_bptree->structure = __pyx_v_structure;
	      |                                ^

This stems from cythonized C code, so I don't see much knobs to
fix it from unifrac source code.  I suspect other packages may
be similarly affected and would benefit from having cython being
able to produce valid gcc-14 C code.  If I trust gcc-14 porting
guide[1], another option if cython cannot produce such C code
would be for it to emit pragmas described in "Accommodating C
code generators" section; this would still be a change to bring
on cython side.

Worst case scenario if the issue is not addressed in cython, it
would still be possible to reduce the severity of the error by
passing -Wno-error=incompatible-pointer-types.  I suggest
keeping this option for when the bug severity is bumped to
serious.

[1]: https://gcc.gnu.org/gcc-14/porting_to.html

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier <emollier at debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/2, please excuse my verbosity
   `-    on air: The Chronicles Of Father Robin - Ocean Travell…
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20240704/efddb6a8/attachment.sig>