[Debian-med-packaging] Bug#1066472: pullseq: FTBFS: pull_by_re.c:76:29: error: implicit declaration of function ‘search_header’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: pullseq
Version: 1.0.2-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -c -o pull_by_size.o pull_by_size.c
> pull_by_re.c: In function ‘pull_by_re’:
> pull_by_re.c:76:29: error: implicit declaration of function ‘search_header’ [-Werror=implicit-function-declaration]
>    76 |                         if (search_header(re, seq->name.s) || search_header(re, seq->comment.s))
>       |                             ^~~~~~~~~~~~~
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -c -o pullseq.o pullseq.c
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -c -o cmpseq.o cmpseq.c
> pullseq.c: In function ‘main’:
> pullseq.c:275:25: error: implicit declaration of function ‘pull_by_re’; did you mean ‘pull_by_size’? [-Werror=implicit-function-declaration]
>   275 |                 count = pull_by_re(in, aStrRegex, min, max, length, exclude, convert, just_count);
>       |                         ^~~~~~~~~~
>       |                         pull_by_size
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -c -o seqdiff.o seqdiff.c
> gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fcommon -c -o seqdiff_results.o seqdiff_results.c
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:413: pull_by_re.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pullseq_1.0.2-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.