[Debian-med-packaging] Bug#1066508: staden: FTBFS: capture.c:33:14: error: implicit declaration of function ‘mkostemp’; did you mean ‘mkstemp’? [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: staden
Version: 2.0.0+b11-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -DUSE_NON_CONST  -I/<<PKGBUILDDIR>>/./tk_utils -I/<<PKGBUILDDIR>>/./Misc -I/<<PKGBUILDDIR>>/./tk_utils -I/usr/include -I"/usr/include/tcl8.6/tk-private/generic" -I"/usr/include/tcl8.6/tk-private/unix" -I"/usr/include/tcl8.6/tk-private/generic/ttk" -I"/usr/include/tcl8.6/tcl-private/generic" -I"/usr/include/tcl8.6/tcl-private/unix" -I/<<PKGBUILDDIR>>/./seq_utils   -I/<<PKGBUILDDIR>> -DSVN_VERSION="" -fPIC   -o capture.o -c capture.c
> capture.c: In function ‘tcl_capture’:
> capture.c:33:14: error: implicit declaration of function ‘mkostemp’; did you mean ‘mkstemp’? [-Werror=implicit-function-declaration]
>    33 |         fd = mkostemp(NULL, 0666);
>       |              ^~~~~~~~
>       |              mkstemp
> capture.c:54:5: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    54 |     read(fd, buf, statbuf.st_size);
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> make[2]: Leaving directory '/<<PKGBUILDDIR>>/eba'
> cc1: some warnings being treated as errors
> make[2]: *** [/<<PKGBUILDDIR>>/./tk_utils/../global.mk:388: capture.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/staden_2.0.0+b11-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.