[Debian-med-packaging] Bug#1066705: wise: FTBFS: prior.c:102:12: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: wise
Version: 2.4.1-23
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include   -c trace.c		
> prior.c: In function ‘P7ReadPrior’:
> prior.c:102:12: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
>   102 |   if      (strcmp(sptr, "DIRICHLET") == 0) pri->strategy = PRI_DCHLET;
>       |            ^~~~~~
> prior.c:10:1: note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
>     9 | #include "funcs.h"
>   +++ |+#include <string.h>
>    10 | #include "squid.h"
> cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -c  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include   -c aligneval.c		
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:69: prior.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/wise_2.4.1-23_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.