[Debian-med-packaging] Bug#1066716: libtfbs-perl: FTBFS: ./lib/pwm_searchPFF.c:55:7: error: implicit declaration of function ‘announce’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: libtfbs-perl
Version: 0.7.1+ds-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> x86_64-linux-gnu-gcc -c  -I. -I./lib -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2   -DVERSION=\"0.2\" -DXS_VERSION=\"0.2\" -fPIC "-I/usr/lib/x86_64-linux-gnu/perl/5.38/CORE"   pwmsearch.c
> In file included from pwmsearch.xs:4:
> ./lib/pwm_searchPFF.c: In function ‘do_search’:
> ./lib/pwm_searchPFF.c:55:7: error: implicit declaration of function ‘announce’ [-Werror=implicit-function-declaration]
>    55 |       announce("+++\nEntering main.\n+++\n");
>       |       ^~~~~~~~
> ./lib/pwm_searchPFF.c:74:9: error: implicit declaration of function ‘get_matrix’ [-Werror=implicit-function-declaration]
>    74 |    if ( get_matrix(&args,pwm) )
>       |         ^~~~~~~~~~
> ./lib/pwm_searchPFF.c:90:14: error: implicit declaration of function ‘loop_on_seqs’ [-Werror=implicit-function-declaration]
>    90 |    else if ( loop_on_seqs(&args,pwm,fp,outfp) )
>       |              ^~~~~~~~~~~~
> ./lib/pwm_searchPFF.c: At top level:
> ./lib/pwm_searchPFF.c:159:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
>   159 | best_pull(pargs,pbase,pstrand,pscore)
>       | ^~~~~~~~~
> ./lib/pwm_searchPFF.c: In function ‘do_seq’:
> ./lib/pwm_searchPFF.c:229:18: error: implicit declaration of function ‘save_hit’; did you mean ‘save_hptr’? [-Werror=implicit-function-declaration]
>   229 |             if ( save_hit(base,0,forward_score,hits,&nhit) )
>       |                  ^~~~~~~~
>       |                  save_hptr
> ./lib/pwm_searchPFF.c:239:20: error: implicit declaration of function ‘output’ [-Werror=implicit-function-declaration]
>   239 |          else if ( output(pargs,seqid,base,seq,0,forward_score,outfp) )
>       |                    ^~~~~~
> ./lib/pwm_searchPFF.c: At top level:
> ./lib/pwm_searchPFF.c:526:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
>   526 | get_sequence(fp,seq_id,sequence)
>       | ^~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:324: pwmsearch.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/libtfbs-perl_0.7.1+ds-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.