[Debian-med-packaging] Bug#1066718: ctn: FTBFS: control.c:568:9: error: implicit declaration of function ‘getpid’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: ctn
Version: 3.2.0~dfsg-7
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -g -DDEBUG -DLITTLE_ENDIAN_ARCHITECTURE -DLINUX -DSHARED_MEMORY -DSEMAPHORE -DX11 -DATHENA -DX11R4 -DUSLEEP -DMYSQLDB -I/<<PKGBUILDDIR>>/include -I/usr/include/mysql -I/usr/include/Xm -I/usr/X11R6/include -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DLONGSIZE=64 -DINTSIZE=32 -DSHORTSIZE=16 -DTIMEOFDAYARGS=2 -DMOTIF -DUSEREGCOMP -I/<<PKGBUILDDIR>>/include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o control.o control.c
> control.c: In function ‘DMAN_TempImageFile’:
> control.c:568:9: error: implicit declaration of function ‘getpid’ [-Werror=implicit-function-declaration]
>   568 |     i = getpid();
>       |         ^~~~~~
> control.c: In function ‘localHostEnt’:
> control.c:715:14: error: implicit declaration of function ‘isdigit’ [-Werror=implicit-function-declaration]
>   715 |         if (!isdigit(node[index]) && !(node[index] == '.')) {
>       |              ^~~~~~~
> control.c:92:1: note: include ‘<ctype.h>’ or provide a declaration of ‘isdigit’
>    91 | #include "dmanprivate.h"
>   +++ |+#include <ctype.h>
>    92 | 
> control.c:724:21: error: implicit declaration of function ‘inet_addr’ [-Werror=implicit-function-declaration]
>   724 |         ipAddress = inet_addr(node);
>       |                     ^~~~~~~~~
> cc1: some warnings being treated as errors
> make[3]: *** [<builtin>: control.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/ctn_3.2.0~dfsg-7_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.