[Debian-med-packaging] Bug#1067147: dcmtk: diff for NMU version 3.6.7-9.2

[Emanuele Rocca]

Hi Aurelien and Michael,

On 2024-03-21 08:54, Aurelien Jarno wrote:
> On 2024-03-19 11:54, Emanuele Rocca wrote:
> > diff -Nru dcmtk-3.6.7/debian/control dcmtk-3.6.7/debian/control
> > --- dcmtk-3.6.7/debian/control	2024-02-28 02:17:02.000000000 +0100
> > +++ dcmtk-3.6.7/debian/control	2024-03-19 11:08:29.000000000 +0100
> > @@ -16,7 +16,7 @@
> >                 libxml2-dev,
> >                 zlib1g-dev
> >  Build-Depends-Indep: doxygen,
> > -                     graphviz
> > +                     graphviz [!armhf !armel]
> 
> This does not look correct. Build-Depends-Indep are only used to build
> the arch:all packages, and currently all the arch:all autobuilder run on
> amd64.

Ah, thanks for spotting this. The change was needed in order to build
locally in a clean armel sbuild environment, but as you say is not
needed on the buildds.

> Therefore it looks to me that this change is not necessary to
> help the armel/armhf rebootstrap done as part of the time_t transition.

Indeed the main goal of the proposed changes was fixing a FTBFS bug in
dcmtk entirely unrelated to the time_t transition (#1060104), but the
relevant changelog entry from my NMU mentioning that was forgotten:

 * Build without stack-clash-protection on armel. See #1060104.

Anyways, what matters is that now dcmtk builds fine on armel in sid with
stackclash disabled.

I've opened https://salsa.debian.org/med-team/dcmtk/-/merge_requests/1
to revert the changes to build-depends-indep.

Thanks,
  Emanuele