[Debian-med-packaging] Bug#1082806: tree-puzzle: please make the build reproducible

[Chris Lamb]

Source: tree-puzzle
Version: 5.3~rc16+dfsg-10
Severity: wishlist
Tags: patch
User: reproducible-builds at lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
tree-puzzle could not be built reproducibly (again).

This is something of a followup from #1005901. Here, however, it looks
like the .puzzle files at fault. Here is the diff on amd64:

│ │ │ ├── ./usr/share/doc/tree-puzzle/examples/tests/qp-hky-rhet-clock-nucl.nucl.puzzle
│ │ │ │ @@ -320,18 +320,18 @@
│ │ │ │   :
│ │ │ │   :-----1 Thylacinus
│ │ │ │   
│ │ │ │  
│ │ │ │           branch  length     S.E.   branch  length     S.E.
│ │ │ │  Thylacinus    1  0.13266  0.07077       9  0.14146  0.08889
│ │ │ │  Sarcophilu    2  0.16398  0.05399      10  0.15536  0.07510
│ │ │ │ -Dasyurus      3  0.00001  0.00399      11  0.07879  0.07178
│ │ │ │ +Dasyurus      3  0.00001  0.00141      11  0.07879  0.07178
│ │ │ │  Echymipera    4  0.20360  0.08378
│ │ │ │  Trichosuru    5  0.15345  0.07805
│ │ │ │ -Phalanger     6  0.18858  0.08737
│ │ │ │ +Phalanger     6  0.18858  0.08736

A patch is attached that cleans the tests directory entirely by using
tree-puzzle's own clean target. Seems much more sensible than playing
whack-a-mole.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-
-------------- next part --------------
--- a/debian/rules	2024-09-26 09:08:18.502165005 -0700
--- b/debian/rules	2024-09-26 09:14:00.523766494 -0700
@@ -31,13 +31,9 @@
 	mv `pwd`/debian/tmp/usr/bin/puzzle `pwd`/debian/$(pkg)/usr/bin/$(pkg)
 	mv `pwd`/debian/tmp/usr/bin/ppuzzle `pwd`/debian/$(ppkg)/usr/bin/$(ppkg)
 
-override_dh_installexamples:
-	rm -f tests/*.log tests/*.trs
-ifneq (,$(filter $(DEB_BUILD_ARCH),i386))
-	# Does not generate deterministic output on i386.
-	rm -f tests/qp-tn-nucl.nucl*
-endif
-	dh_installexamples
+execute_before_dh_installexamples:
+	# Don't install output generated by tests, some of which is nodeterminstic
+	$(MAKE) -C tests clean
 
 override_dh_fixperms:
 	dh_fixperms