[Debian-med-packaging] Bug#1096305: ampliconnoise: ftbfs with GCC-15

[Matthias Klose]

Package: src:ampliconnoise
Version: 1.29-15
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/ampliconnoise_1.29-15_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
  210 |       fgets(szLine, MAX_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘readMapFile’:
SplitClusterClust.c:282:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  282 |       fgets(szLine, BIG_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘main’:
SplitClusterClust.c:52:29: warning: ‘%s’ directive writing up to 1023 bytes into a region of size between 0 and 1023 [-Wformat-overflow=]
   52 |       sprintf(szDatFile,"%s/%s%s",szDir,szDir,DAT_SUFFIX);
      |                             ^~          ~~~~~
In file included from /usr/include/stdio.h:970,
                 from SplitClusterClust.c:1:
In function ‘sprintf’,
    inlined from ‘main’ at SplitClusterClust.c:52:7:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 6 and 2052 bytes into a destination of size 1024
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
SplitClusterClust.c: In function ‘main’:
SplitClusterClust.c:88:29: warning: ‘%s’ directive writing up to 1023 bytes into a region of size between 0 and 1023 [-Wformat-overflow=]
   88 |       sprintf(szDatFile,"%s/%s%s",szDir,szDir,DAT_SUFFIX);
      |                             ^~          ~~~~~
In function ‘sprintf’,
    inlined from ‘main’ at SplitClusterClust.c:88:7:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 6 and 2052 bytes into a destination of size 1024
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
linking...
gcc -Wl,-z,relro -Wl,-z,now -o SplitClusterClust SplitClusterClust.o -lm 
make[2]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29/SplitClusterClust'
(cd Perseus && CFLAGS="-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ampliconnoise-1.29=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection" LDFLAGS="-Wl,-z,relro -Wl,-z,now" make)
make[2]: Entering directory '/build/reproducible-path/ampliconnoise-1.29/Perseus'
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ampliconnoise-1.29=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O3 -c Perseus.c
Perseus.c: In function ‘main’:
Perseus.c:56:3: error: too many arguments to function ‘initLookUp’; expected 0, have 1
   56 |   initLookUp(&tParams);
      |   ^~~~~~~~~~ ~~~~~~~~
In file included from Perseus.c:17:
Perseus.h:151:6: note: declared here
  151 | void initLookUp();
      |      ^~~~~~~~~~
Perseus.c: At top level:
Perseus.c:1232:6: error: conflicting types for ‘initLookUp’; have ‘void(t_Params *)’ {aka ‘void(struct s_Params *)’}
 1232 | void initLookUp(t_Params *ptParams)
      |      ^~~~~~~~~~
Perseus.h:151:6: note: previous declaration of ‘initLookUp’ with type ‘void(void)’
  151 | void initLookUp();
      |      ^~~~~~~~~~
Perseus.c: In function ‘initLookUp’:
Perseus.c:1249:7: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1249 |       fgets(szLine, MAX_LINE_LENGTH, ifp);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Perseus.c: In function ‘calcLoonIndex’:
Perseus.c:1640:3: warning: ignoring return value of ‘system’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
 1640 |   system(szCommand);
      |   ^~~~~~~~~~~~~~~~~
make[2]: *** [makefile:13: Perseus.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29/Perseus'
make[1]: *** [makefile:13: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/ampliconnoise-1.29'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:18: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2