[Debian-med-packaging] Bug#1097436: ncbi-seg: ftbfs with GCC-15

[Matthias Klose]

Package: src:ncbi-seg
Version: 0.0.20000620-7
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/ncbi-seg_0.0.20000620-7_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                         ^~~~~~~
seg.c:778:7: error: too many arguments to function ‘lower’; expected 0, have 2
  778 |       lower(curseq = win->seq, win->length);
      |       ^~~~~ ~~~~~~~~~~~~~~~~~
genwin.h:160:17: note: declared here
  160 | extern upper(), lower(), findchar();
      |                 ^~~~~
seg.c:802:17: error: too many arguments to function ‘closewin’; expected 0, have 1
  802 |                 closewin(win);
      |                 ^~~~~~~~ ~~~
genwin.h:152:20: note: declared here
  152 | extern shiftwin(), closewin();
      |                    ^~~~~~~~
seg.c: At top level:
seg.c:811:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
  811 | space(len)
      | ^~~~~
seg.c: In function ‘space’:
seg.c:811:1: warning: old-style function definition [-Wold-style-definition]
seg.c: At top level:
seg.c:832:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
  832 | seqout(seq, hilo, begin, end)
      | ^~~~~~
seg.c: In function ‘seqout’:
seg.c:832:1: warning: old-style function definition [-Wold-style-definition]
seg.c:856:11: error: too many arguments to function ‘findchar’; expected 0, have 2
  856 |    iend = findchar(header, ' ');
      |           ^~~~~~~~ ~~~~~~
genwin.h:160:26: note: declared here
  160 | extern upper(), lower(), findchar();
      |                          ^~~~~~~~
seg.c:881:7: error: too many arguments to function ‘lower’; expected 0, have 2
  881 |       lower(proseq, seq->length);
      |       ^~~~~ ~~~~~~
genwin.h:160:17: note: declared here
  160 | extern upper(), lower(), findchar();
      |                 ^~~~~
seg.c:885:7: error: too many arguments to function ‘upper’; expected 0, have 2
  885 |       upper(proseq, seq->length);
      |       ^~~~~ ~~~~~~
genwin.h:160:8: note: declared here
  160 | extern upper(), lower(), findchar();
      |        ^~~~~
seg.c:889:7: error: too many arguments to function ‘lower’; expected 0, have 2
  889 |       lower(proseq, seq->length);
      |       ^~~~~ ~~~~~~
genwin.h:160:17: note: declared here
  160 | extern upper(), lower(), findchar();
      |                 ^~~~~
seg.c: At top level:
seg.c:906:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
  906 | appendseg(segs, seg)
      | ^~~~~~~~~
seg.c: In function ‘appendseg’:
seg.c:906:1: warning: old-style function definition [-Wold-style-definition]
seg.c: At top level:
seg.c:930:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
  930 | freesegs(segs)
      | ^~~~~~~~
seg.c: In function ‘freesegs’:
seg.c:930:1: warning: old-style function definition [-Wold-style-definition]
seg.c: At top level:
seg.c:945:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
  945 | usage()
      | ^~~~~
make[1]: *** [Makefile:413: seg.o] Error 1
make[1]: Leaving directory '/build/reproducible-path/ncbi-seg-0.0.20000620'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:15: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2