[Debian-med-packaging] Bug#1097885: sim4: ftbfs with GCC-15

[Matthias Klose]

Package: src:sim4
Version: 0.0.20121010-8
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/sim4_0.0.20121010-8_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
sim4.init.c: In function ‘cds_range’:
sim4.init.c:672:6: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  672 |      if (*s!='.') fatal ("Illegal CDS specification."); s++;
      |      ^~
sim4.init.c:672:57: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  672 |      if (*s!='.') fatal ("Illegal CDS specification."); s++;
      |                                                         ^
sim4.init.c:673:6: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  673 |      if (*s!='.') fatal ("Illegal CDS specification."); s++;
      |      ^~
sim4.init.c:673:57: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  673 |      if (*s!='.') fatal ("Illegal CDS specification."); s++;
      |                                                         ^
sim4.init.c: At top level:
sim4.init.c:61:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=]
   61 | static const char rcsid[] =
      |                   ^~~~~
In file included from psublast.h:6,
                 from sim4b1.c:18:
types.h:7:13: error: ‘bool’ cannot be defined via ‘typedef’
    7 | typedef int bool;
      |             ^~~~
types.h:7:13: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
types.h:7:1: warning: useless type name in empty declaration
    7 | typedef int bool;
      | ^~~~~~~
sim4b1.c: In function ‘heapify’:
sim4b1.c:1075:13: warning: old-style function definition [-Wold-style-definition]
 1075 | static void heapify(i, last)
      |             ^~~~~~~
sim4b1.c: In function ‘smaller’:
sim4b1.c:1097:12: warning: old-style function definition [-Wold-style-definition]
 1097 | static int smaller(i, j)
      |            ^~~~~~~
sim4b1.c: In function ‘find_ends’:
sim4b1.c:1523:27: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 1523 |                           if (j>=j0) return (i-(j-j0)); break;
      |                           ^~
sim4b1.c:1523:57: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
 1523 |                           if (j>=j0) return (i-(j-j0)); break;
      |                                                         ^~~~~
sim4b1.c: At top level:
sim4b1.c:8:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=]
    8 | static const char rcsid[] =
      |                   ^~~~~
In file included from psublast.h:6,
                 from splice.c:3:
types.h:7:13: error: ‘bool’ cannot be defined via ‘typedef’
    7 | typedef int bool;
      |             ^~~~
types.h:7:13: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
types.h:7:1: warning: useless type name in empty declaration
    7 | typedef int bool;
      | ^~~~~~~
splice.c: In function ‘splice’:
splice.c:45:67: warning: variable ‘keep_Gi’ set but not used [-Wunused-but-set-variable]
   45 |    int maxCscore, maxGscore, Gxs, Gxe, Gy, Cxs, Cxe, Cy, keep_Ci, keep_Gi;
      |                                                                   ^~~~~~~
splice.c:45:58: warning: variable ‘keep_Ci’ set but not used [-Wunused-but-set-variable]
   45 |    int maxCscore, maxGscore, Gxs, Gxe, Gy, Cxs, Cxe, Cy, keep_Ci, keep_Gi;
      |                                                          ^~~~~~~
splice.c: At top level:
splice.c:8:19: warning: ‘rcsid’ defined but not used [-Wunused-const-variable=]
    8 | static const char rcsid[] =
      |                   ^~~~~
make[1]: *** [Makefile:11: sim4] Error 1
make[1]: Leaving directory '/build/reproducible-path/sim4-0.0.20121010'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2