[Debian-med-packaging] Bug#1097934: staden: ftbfs with GCC-15

[Matthias Klose]

Package: src:staden
Version: 2.0.0+b11-5
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/staden_2.0.0+b11-5_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
   21 |                                    expand_6,
      |                                    ^~~~~~~~
align.c:21:36: note: (near initialization for ‘expand_arr[1]’)
align_lib_old.h:11:13: note: ‘expand_6’ declared here
   11 | extern void expand_6(char *A, FastInt (*B)[6], int M, int N,
      |             ^~~~~~~~
align.c:22:36: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(char *, FastInt (*)[6], int,  int,  char *, FastInt (*)[6], int *, int *, FastInt *, int)’ {aka ‘void (*)(char *, int (*)[6], int,  int,  char *, int (*)[6], int *, int *, int *, int)’} [-Wincompatible-pointer-types]
   22 |                                    expand_6,
      |                                    ^~~~~~~~
align.c:22:36: note: (near initialization for ‘expand_arr[2]’)
align_lib_old.h:11:13: note: ‘expand_6’ declared here
   11 | extern void expand_6(char *A, FastInt (*B)[6], int M, int N,
      |             ^~~~~~~~
align.c:23:36: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(char *, char *, int,  int,  char *, char *, int *, int *, FastInt *, int)’ {aka ‘void (*)(char *, char *, int,  int,  char *, char *, int *, int *, int *, int)’} [-Wincompatible-pointer-types]
   23 |                                    expand};
      |                                    ^~~~~~
align.c:23:36: note: (near initialization for ‘expand_arr[3]’)
align_lib_old.h:8:13: note: ‘expand’ declared here
    8 | extern void expand(char *A, char *B, int M, int N,
      |             ^~~~~~
align_sv.c: In function ‘align’:
align_sv.c:55:16: warning: old-style function definition [-Wold-style-definition]
   55 | static FastInt align(A,B,M,N,tb,te,topr,botr,lc,rc)
      |                ^~~~~
align.c: In function ‘calignm’:
align.c:120:14: error: too many arguments to function ‘align_arr[ajob]’; expected 0, have 14
  120 |     retval = align_arr[ajob](seq1, seq2, (FastInt)len1, (FastInt)len2,
      |              ^~~~~~~~~       ~~~~
align.c:134:13: error: too many arguments to function ‘expand_arr[ajob]’; expected 0, have 10
  134 |             expand_arr[ajob](seq1, seq2, len1, len2,
      |             ^~~~~~~~~~       ~~~~
align.c: In function ‘cdisplay’:
align.c:169:5: error: too many arguments to function ‘display_arr[job & 15]’; expected 0, have 7
  169 |     display_arr[job & ALIGN_J_MASK](seq1, seq2, len1, len2,
      |     ^~~~~~~~~~~                     ~~~~
align.c: In function ‘cexpand’:
align.c:188:5: error: too many arguments to function ‘expand_arr[job & 15]’; expected 0, have 10
  188 |     expand_arr[job & ALIGN_J_MASK](seq1, seq2, len1, len2,
      |     ^~~~~~~~~~                     ~~~~
align_sv.c: In function ‘align_sv’:
align_sv.c:339:9: warning: old-style function definition [-Wold-style-definition]
  339 | FastInt align_sv(A,B,M,N,low,up,W,G,H,S,s1,s2,e1,e2)
      |         ^~~~~~~~
align_sv.c: In function ‘display_sv’:
align_sv.c:456:6: warning: old-style function definition [-Wold-style-definition]
  456 | void display_sv(A,B,M,N,S,AP,BP)
      |      ^~~~~~~~~~
make[2]: *** [/build/reproducible-path/staden-2.0.0+b11/./seq_utils/../global.mk:388: align.o] Error 1
make[2]: *** Waiting for unfinished jobs....
renz_utils.c: In function ‘SetREnzColour’:
renz_utils.c:1049:35: warning: ‘__builtin___sprintf_chk’ writing a terminating nul past the end of the destination [-Wformat-overflow=]
 1049 |     sprintf(colour, "#%02x%02x%02x", r, g, b);
      |                                   ^
In file included from /usr/include/stdio.h:970,
                 from renz_utils.c:3:
In function ‘sprintf’,
    inlined from ‘SetREnzColour’ at renz_utils.c:1049:5:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 8 and 26 bytes into a destination of size 7
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/build/reproducible-path/staden-2.0.0+b11/seq_utils'
make[1]: *** [Makefile:174: seq_utils] Error 2
make[1]: Leaving directory '/build/reproducible-path/staden-2.0.0+b11'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:12: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2