[Debian-med-packaging] Bug#1100833: dipy: FTBFS on s390x: two tests failing

[Drew Parsons]

On 2025-03-22 13:22, Santiago Vila wrote:
> Hi.
> 
> I've just made a team upload trying to address this.
> 
>> The skips would probably needs to be added to both debian/rules and
>> debian/tests.
> 
> I was unsure about how to do that, but then I looked at the 
> autopkgtests logs
> and realized that the tests marked to be skipped in debian/rules are 
> also
> skipped when the autopkgtests run.
> 
> Apparently pybuild-autopkgtest has some kind of magic that reads 
> variables
> from debian/rules so that we don't have to define things twice, which
> is great.
> 
> So I hope what I did will work. If it does not, I'll probably need help 
> to
> complete the fix.

That will work fine (and s390x is now built, thank you!)
I forgot that dipy debian/rules simply calls debian/tests, which makes 
it simpler.

For the general case of applying the skips separately in both 
debian/rules and debian/tests,
there are examples in openmm and elsewhere (scipy, mpi4py, scikit-learn, 
mdanalysis, etc)

openmm is the most recent one I added it to, so I'd suggest it as "best 
practice".

The little tricks are things like defining SKIP_TESTS in debian/rules 
outside the dh_ rules (scipy does it inside), and using "" with 
"${SKIP_TEST_LIST[@]}" in debian/tests to allow for complex multipart 
skip definitions.