[Debian-med-packaging] Bug#962589: seqtools: please make the build reproducible

[Santiago Vila]

On Wed, Jun 10, 2020 at 01:00:22PM +0100, Chris Lamb wrote:
> Source: seqtools
> Version: 4.44.1+dfsg-4
> Severity: wishlist
> Tags: patch
> User: reproducible-builds at lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs at lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0] we noticed that
> seqtools could not be built reproducibly. This is because it contains
> `Makefile.in` and `Makefile` example build files that are generated
> from Makefile.am. The `Makefile` contains the absolute build path
> which leaves the binary package unreproducible.
> 
> Patch attached that simply does not ship these generated files.

Hello. I've unarchived this to add this comment :-)

> --- a/debian/rules	2020-06-10 12:23:36.358145956 +0100
> --- b/debian/rules	2020-06-10 12:50:35.382770860 +0100
> @@ -18,3 +18,4 @@
>  		    --movedev debian/tmp/usr/include/* usr/include \
>  		    debian/tmp/usr/lib/*/*.so
>  	find debian -name "*.la" -delete
> +	rm -f examples/Makefile.in examples/Makefile

This had a funny unintended side effect:

The Makefile in the toplevel directory, when invoked as "make distclean"
and acting recursively on several directories, started to fail, and
triggered a "fails to build source after binary build"-bug from Lucas.

I've now fixed the reproducibility problem by specifying the exact files
that we want in examples in libgbtools-dev.examples, excluding any
Makefile-type file, as those are not really of interest.

Thanks.