[Debian-med-packaging] Bug#1117106: sight: (unnecessarily?) Build-Depends on dbus-x11 (dbus-launch)

[Simon McVittie]

On Fri, 03 Oct 2025 at 11:19:12 +0200, Flavien Bridault wrote:
>Indeed we don't run tests during build. I have no idea why we require 
>this package, we don't rely on dbus directly. For me it was there to 
>make the Debian build system happy or something like that.

Try removing it and see whether a build in a minimal environment (sbuild 
or pbuilder or Salsa-CI) still works? If yes, then it can probably be 
removed permanently.

(sight doesn't currently compile successfully even *with* dbus-x11 - see 
#1097881 and #1111550 - so fixing those will be a prerequisite for 
finding out whether it can compile successfully *without* dbus-x11!)

>So could help me understand if dbus-daemon or dbus-bin is required ?

You need dbus-bin if you run dbus-send, dbus-monitor, dbus-uuidgen, 
dbus-update-activation-environment or dbus-cleanup-sockets.

You need dbus-daemon if you run dbus-daemon or dbus-run-session.

If this package doesn't interact directly with D-Bus, then you probably 
don't need either of those and can just remove the build-dep.

Build-dependencies on D-Bus things are usually either because 
build-time tests need it, or because the upstream build system checks 
for something that is going to be necessary at runtime, like for example

     find_program(DBUS_DAEMON dbus-daemon)

and if you don't have something like that in the upstream build system 
then you probably don't need it.

     smcv