[Debian-med-packaging] Bug#1118336: ncbi-entrez-direct: Fragile manual dependency setup causes FTBFS

[Mathias Gibbens]

Source: ncbi-entrez-direct
Version: 24.0.20250523+dfsg-1
Severity: serious
Justification: FTBFS
Tags: sid ftbfs patch

  I am updating golang-github-go-playground-validator-v10, which
includes a new dependency. This change has revealed what appears to be
a fragile manual dependency setup of the golang sources in ncbi-entrez-
direct's d/rules.

  The fix is easy enough (see end of message), but I think it would be
better to rely on dh-golang's abilities to properly setup the build
environment for the golang part of this package.

  The error is:

> [snip]
> mkdir -p /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/gopkg.in/
> ln -s /usr/share/gocode/src/gopkg.in/yaml.v2 /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/gopkg.in/yaml.v2
> mkdir -p /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/github.com/klauspost
> ln -s /usr/share/gocode/src/github.com/klauspost/cpuid/v2 \
>     /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/github.com/klauspost/cpuid
> go build -v -gccgoflags '-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wl,-z,relro -Wl,-z,now' -o bin/edict \
>     /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/main/edict.go
> obj-x86_64-linux-gnu/src/github.com/go-playground/validator/v10/baked_in.go:28:2: cannot find package "github.com/gabriel-vasile/mimetype" in any of:
>         /usr/lib/go-1.24/src/github.com/gabriel-vasile/mimetype (from $GOROOT)
>         /build/reproducible-path/ncbi-entrez-direct-24.0.20250523+dfsg/obj-x86_64-linux-gnu/src/github.com/gabriel-vasile/mimetype (from $GOPATH)
> make[1]: *** [debian/rules:141: bin/edict] Error 1

  And the patch:

> diff --git a/debian/rules b/debian/rules
> index 67a5524..d158a58 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -56,6 +56,7 @@ GOLIBSRC_ = $(GH)/fatih/color $(GH)/gedex/inflector \
>              $(GH)/go-playground/locales \
>              $(GH)/go-playground/universal-translator \
>              $(GH)/go-playground/validator/v10 $(GH)/goccy/go-yaml \
> +            $(GH)/gabriel-vasile/mimetype \
>              $(GH)/klauspost/compress $(GH)/klauspost/cpuid \
>              $(GH)/klauspost/pgzip $(GH)/komkom/toml $(GH)/leodido/go-urn \
>              $(GH)/mattn/go-colorable $(GH)/mattn/go-isatty \
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/debian-med-packaging/attachments/20251018/90f7c3b5/attachment.sig>