[Debian-med-packaging] Bug#1133600: oscar: ftbfs with GCC-16

[Emanuele Rocca]

Package: src:oscar
Version: 1.5.3-3
Severity: important
Tags: sid forky ftbfs
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-16

Hi,

oscar fails to build in a test rebuild on at least amd64 and arm64 with
gcc-16/g++-16, but builds properly with gcc-15/g++-15. The severity of this
report will be raised before the forky release.

The full build log can be found at:
https://people.debian.org/~ema/gcc-16-rebuilds/output-1/oscar_arm64.build.xz

The last lines of the build log are at the end of this report.

To build with GCC 16, either set CC=gcc-16 CXX=g++-16 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures include unused (but set) variables, array subscripts
partly outside array bounds, and new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-16/porting_to.html

Please only close this issue after double-checking that the package can be
built correctly with GCC 16.

Please do not reassign this bug to another package. If a fix in another package
is required, then file a bug for the other package (or clone), and mark this
bug as blocked by the bug in the other package.

[...]


      |            ^~~~~~~
../../oscar/SleepLib/loader_plugins/sleepstyle_loader.cpp: In member function ‘bool SleepStyleLoader::OpenSummary(Machine*, const QString&)’:
../../oscar/SleepLib/loader_plugins/sleepstyle_loader.cpp:681:9: error: variable ‘nblock’ set but not used [-Werror=unused-but-set-variable=]
  681 |     int nblock = 0;
      |         ^~~~~~
../../oscar/SleepLib/loader_plugins/sleepstyle_loader.cpp: In member function ‘bool SleepStyleLoader::OpenDetail(Machine*, const QString&)’:
../../oscar/SleepLib/loader_plugins/sleepstyle_loader.cpp:923:14: error: variable ‘PRSessCount’ set but not used [-Werror=unused-but-set-variable=]
  923 |         long PRSessCount = 0;
      |              ^~~~~~~~~~~
../../oscar/Graphs/MinutesAtPressure.cpp: In member function ‘void RecalcMAP::updateEventsChannel(Session*, ChannelID, QVector<int>&, PressureInfo&)’:
../../oscar/Graphs/MinutesAtPressure.cpp:465:9: error: variable ‘qtyEvents’ set but not used [-Werror=unused-but-set-variable=]
  465 |     int qtyEvents=0;
      |         ^~~~~~~~~
../../oscar/Graphs/gOverviewGraph.cpp: In member function ‘virtual void gOverviewGraph::paint(QPainter&, gGraph&, const QRegion&)’:
../../oscar/Graphs/gOverviewGraph.cpp:472:9: error: variable ‘daynum’ set but not used [-Werror=unused-but-set-variable=]
  472 |     int daynum = 0;
      |         ^~~~~~
../../oscar/Graphs/gOverviewGraph.cpp:562:9: error: variable ‘incompliant’ set but not used [-Werror=unused-but-set-variable=]
  562 |     int incompliant = 0;
      |         ^~~~~~~~~~~
../../oscar/SleepLib/calcs.cpp: In function ‘int calcSPO2Drop(Session*)’:
../../oscar/SleepLib/calcs.cpp:1501:9: error: variable ‘cnt’ set but not used [-Werror=unused-but-set-variable=]
 1501 |     int cnt = 0;
      |         ^~~
../../oscar/SleepLib/journal.cpp: In static member function ‘static bool Journal::RestoreJournal(QString)’:
../../oscar/SleepLib/journal.cpp:391:9: error: variable ‘error’ set but not used [-Werror=unused-but-set-variable=]
  391 |     int error=0;
      |         ^~~~~
../../oscar/SleepLib/journal.cpp:392:9: error: variable ‘ignored’ set but not used [-Werror=unused-but-set-variable=]
  392 |     int ignored=0;
      |         ^~~~~~~
../../oscar/SleepLib/journal.cpp:393:9: error: variable ‘used’ set but not used [-Werror=unused-but-set-variable=]
  393 |     int used=0;
      |         ^~~~
../../oscar/reports.cpp: In static member function ‘static void Report::PrintReport(gGraphView*, QString, QDate)’:
../../oscar/reports.cpp:536:9: error: variable ‘gcnt’ set but not used [-Werror=unused-but-set-variable=]
  536 |     int gcnt = 0;
      |         ^~~~
../../oscar/SleepLib/machine.cpp: In member function ‘bool Machine::Save()’:
../../oscar/SleepLib/machine.cpp:1148:9: error: variable ‘cnt’ set but not used [-Werror=unused-but-set-variable=]
 1148 |     int cnt = 0;
      |         ^~~
../../oscar/Graphs/gGraphView.cpp: In member function ‘bool gGraphView::renderGraphs(QPainter&)’:
../../oscar/Graphs/gGraphView.cpp:1416:9: error: variable ‘pinned_graphs’ set but not used [-Werror=unused-but-set-variable=]
 1416 |     int pinned_graphs = 0; // count
      |         ^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2608: machine_loader.o] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2504: calcs.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:3254: MinutesAtPressure.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2770: sleepstyle_loader.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:3289: journal.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2592: machine.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2045: reports.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:2432: gOverviewGraph.o] Error 1
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1635: gGraphView.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/oscar-1.5.3/_build/oscar'
make[1]: *** [Makefile:47: sub-oscar-make_first-ordered] Error 2
make[1]: Leaving directory '/build/reproducible-path/oscar-1.5.3/_build'
dh_auto_build: error: cd _build && make -j128 returned exit code 2
make: *** [debian/rules:11: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2