[Debian-med-packaging] Bug#1128615: lastz: FTBFS with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: lastz
Version: 1.04.52-1
Severity: important
Tags: ftbfs upstream
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

lastz fails to build from source with glibc 2.43, currently in
experimental. From the build log:

|    dh_auto_build
| 	make -j128 INSTALL="install --strip-program=true"
| make[1]: Entering directory '/build/reproducible-path/lastz-1.04.52'
| cd src && make lastz lastz_D
| make[2]: Entering directory '/build/reproducible-path/lastz-1.04.52/src'

...

| gcc -Wdate-time -D_FORTIFY_SOURCE=2 -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/lastz-1.04.52=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wno-stringop-truncation -O3 -Wall -Wextra -Werror -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DVERSION_MAJOR="\"1"\" -DVERSION_MINOR="\"04"\" -DVERSION_SUBMINOR="\"52"\" -DREVISION_DATE="\"20250402"\" -DSUBVERSION_REV="\""\" -Dscore_type=D sequences.c -o sequences_D.o
| gcc -Wdate-time -D_FORTIFY_SOURCE=2 -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/lastz-1.04.52=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wno-stringop-truncation -O3 -Wall -Wextra -Werror -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DVERSION_MAJOR="\"1"\" -DVERSION_MINOR="\"04"\" -DVERSION_SUBMINOR="\"52"\" -DREVISION_DATE="\"20250402"\" -DSUBVERSION_REV="\""\" -Dscore_type=D capsule.c -o capsule_D.o
| sequences.c: In function ‘parse_sequence_name’:
| sequences.c:8090:17: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|  8090 |         parse   = strstr (name, "::");
|       |                 ^
| sequences.c:8091:17: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|  8091 |         actions = strchr (name, '[');
|       |                 ^
| sequences.c: In function ‘parse_sequence_name’:
| sequences.c:8090:17: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|  8090 |         parse   = strstr (name, "::");
|       |                 ^
| sequences.c:8091:17: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|  8091 |         actions = strchr (name, '[');
|       |                 ^
| cc1: all warnings being treated as errors
| make[2]: *** [Makefile:96: sequences.o] Error 1
| make[2]: *** Waiting for unfinished jobs....
| cc1: all warnings being treated as errors
| make[2]: *** [Makefile:99: sequences_D.o] Error 1
| make[2]: Leaving directory '/build/reproducible-path/lastz-1.04.52/src'
| make[1]: *** [Makefile:16: build_lastz] Error 2
| make[1]: Leaving directory '/build/reproducible-path/lastz-1.04.52'
| dh_auto_build: error: make -j128 INSTALL="install --strip-program=true" returned exit code 2
| make: *** [debian/rules:13: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].

I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/lastz_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net