[Debian-med-packaging] Bug#1128753: sra-sdk: FTBFS with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: sra-sdk
Version: 3.2.1+dfsg-5
Severity: important
Tags: ftbfs upstream
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

sra-sdk fails to build from source with glibc 2.43, currently in
experimental. From the build log:

| In file included from /usr/include/features.h:539,
|                  from /usr/include/aarch64-linux-gnu/bits/libc-header-start.h:33,
|                  from /usr/include/stdint.h:26,
|                  from /usr/lib/gcc/aarch64-linux-gnu/15/include/stdint.h:11,
|                  from /usr/include/ncbi-vdb/kfc/defs.h:34,
|                  from /usr/include/ncbi-vdb/klib/defs.h:31,
|                  from /build/reproducible-path/sra-sdk-3.2.1+dfsg/libs/inc/search/grep.h:35,
|                  from /build/reproducible-path/sra-sdk-3.2.1+dfsg/test/search/../../libs/search/search-priv.h:30,
|                  from /build/reproducible-path/sra-sdk-3.2.1+dfsg/test/search/agrep-main.c:29:
| /build/reproducible-path/sra-sdk-3.2.1+dfsg/test/search/agrep-main.c:26:15: error: expected identifier or ‘(’ before ‘_Generic’
|    26 | #define index strchr
|       |               ^~~~~~
| make[3]: Leaving directory '/build/reproducible-path/sra-sdk-3.2.1+dfsg/obj-aarch64-linux-gnu'

...

| make[1]: *** [Makefile:169: all] Error 2
| make[1]: Leaving directory '/build/reproducible-path/sra-sdk-3.2.1+dfsg/obj-aarch64-linux-gnu'
| dh_auto_build: error: cd obj-aarch64-linux-gnu && make -j128 INSTALL="install --strip-program=true" VERBOSE=1 returned exit code 2
| make: *** [debian/rules:24: binary] Error 25
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].

I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/sra-sdk_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net