<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">FYI. I received a reply to my upstream inquiry. In this light it is probably enough to update the symbols file — any comments?<div class=""><br class=""></div><div class="">Best</div><div class="">Sascha<br class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">Begin forwarded message:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">John Marshall <<a href="mailto:notifications@github.com" class="">notifications@github.com</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Re: [htslib] Missing symbols in htslib 1.3 (#311)</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">30 December 2015 at 01:10:08 CET<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">samtools/htslib <<a href="mailto:htslib@noreply.github.com" class="">htslib@noreply.github.com</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Cc: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Sascha Steinbiss <<a href="mailto:satta@tetrinetsucht.de" class="">satta@tetrinetsucht.de</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Reply-To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">samtools/htslib <<a href="mailto:reply+00006c5472af1d04666d0d204127b7fe850b0c6792129fa292cf00000001129ae2e092a169ce0760b63d@reply.github.com" class="">reply+00006c5472af1d04666d0d204127b7fe850b0c6792129fa292cf00000001129ae2e092a169ce0760b63d@reply.github.com</a>><br class=""></span></div><br class=""><div class=""><p class=""><code class="">bcf_empty1()</code> was previously not declared or even mentioned in a header file, so was not useable in previous htslib releases. Effectively <code class="">bcf_empty()</code> and <code class="">bcf_empty1()</code> have been <strong class="">freshly added</strong> to the public htslib API in 1.3. See <a href="https://github.com/samtools/htslib/commit/d4482eb578aada0080eb30239ff57e9f6a6de93b" class="commit-link"><tt class="">d4482eb</tt></a> for details.</p><p class=""><code class="">int32_get()</code> and <code class="">int32_put()</code> were internal functions private to the library. They were not declared in any header file and were not part of the API. Similarly <code class="">hts_idx_load_local()</code> is not declared in any header and is not part of the API, so making it <code class="">static</code> was intended and does not affect either public API or ABI.</p><p class=""><code class="">MD5_Update()</code>/<code class="">MD5_Final()</code>/<code class="">MD5_Init()</code> were badly-named internal functions private to the library. Defining these functions with their OpenSSL names (and via implementations unlikely to be using the context data compatibly) was a bug, and removing them fixed the bug. See <a href="https://github.com/samtools/htslib/commit/3accd1934472e2bdd501404f4c1a2e570f868cd1" class="commit-link"><tt class="">3accd19</tt></a> and PR <a href="https://github.com/samtools/htslib/pull/180" class="issue-link js-issue-link" data-url="https://github.com/samtools/htslib/issues/180" data-id="58624144" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#180</a> for details.</p><p class="">There were no declarations for these <code class="">MD5_*</code> functions in HTSlib's header files and they were not part of the HTSlib API. To be affected by this change, client code would have to be including declarations from OpenSSL headers and linking against libhts.so and libssl.so, in which case functions previously satisfied by libhts will be satisfied by libssl and all will be well; or it would have to be including OpenSSL headers but linking only against libhts.so, in which case it will fail and deservedly so.</p><p class="">None of these symbols that have been removed from the library are part of the public HTSlib API, and none of them even appear in previous releases' public header files. Thus to use these symbols, client code would have had to go out of its way to create its own declarations for these functions — which is a kind of client code that essentially <strong class="">no</strong> library supports.</p><p class="">We considered each of these symbol removals as we made them, and judged in each case that as they are not part of the documented/supported HTSlib API their removal does not cause backwards-compatibility problems and does not constitute a change in the library's public ABI. Therefore we considered that no soversion bump was necessary.</p><p class="">Now that you have the rationale for each case, we hope that Debian will agree that neither the proposed <em class="">fixup_symbols.patch.txt</em> wrappers nor a soversion bump are needed.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;" class="">—<br class="">Reply to this email directly or <a href="https://github.com/samtools/htslib/issues/311#issuecomment-167903183" class="">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AABsVMxlRVC8Fn34IrcPwk6oXLod2Tqbks5pUxhggaJpZM4G6_vf.gif" width="1" class=""></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage" class="">
<div itemprop="action" itemscope="" itemtype="http://schema.org/ViewAction" class="">
<link itemprop="url" href="https://github.com/samtools/htslib/issues/311#issuecomment-167903183" class="">
<meta itemprop="name" content="View Issue" class="">
</div>
<meta itemprop="description" content="View this Issue on GitHub" class="">
</div>
</div></blockquote></div><br class=""></div></div></body></html>