<div dir="ltr"><div>Control: forwarded <a href="https://github.com/amplab/snap/issues/68">https://github.com/amplab/snap/issues/68</a></div><div><br></div>Thank you Aaron for your reports.<div><br></div><div>x32 is out of my league; and I suspect outside of upstream's interest though I have still reported it there for completeness. <br><br>I made the suggested change but it wasn't sufficient:</div><div><br></div><div><div>g++ -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -MMD -ISNAPLib -Wdate-time -D_FORTIFY_SOURCE=2 -c -o SNAPLib/SortedDataWriter.o SNAPLib/SortedDataWriter.cpp</div><div>SNAPLib/SortedDataWriter.cpp: In member function 'bool SortedDataFilterSupplier::mergeSort()':</div><div>SNAPLib/SortedDataWriter.cpp:339:86: error: no matching function for call to 'max(long long unsigned int, _int64)'</div><div> min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace / blocks.size()))); // 128kB to 8MB buffer space per block</div><div> ^</div><div>In file included from /usr/include/c++/5/algorithm:61:0,</div><div> from SNAPLib/stdafx.h:13,</div><div> from SNAPLib/SortedDataWriter.cpp:19:</div><div>/usr/include/c++/5/bits/stl_algobase.h:265:5: note: candidate: template<class _Tp, class _Compare> const _Tp& std::max(const _Tp&, const _Tp&, _Compare)</div><div> max(const _Tp& __a, const _Tp& __b, _Compare __comp)</div><div> ^</div><div>/usr/include/c++/5/bits/stl_algobase.h:265:5: note: template argument deduction/substitution failed:</div><div>SNAPLib/SortedDataWriter.cpp:339:86: note: deduced conflicting types for parameter 'const _Tp' ('long long unsigned int' and '_int64 {aka long long int}')</div><div> min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace / blocks.size()))); // 128kB to 8MB buffer space per block</div><div> ^</div><div>In file included from /usr/include/c++/5/algorithm:61:0,</div><div> from SNAPLib/stdafx.h:13,</div><div> from SNAPLib/SortedDataWriter.cpp:19:</div><div>/usr/include/c++/5/bits/stl_algobase.h:219:5: note: candidate: template<class _Tp> const _Tp& std::max(const _Tp&, const _Tp&)</div><div> max(const _Tp& __a, const _Tp& __b)</div><div> ^</div><div>/usr/include/c++/5/bits/stl_algobase.h:219:5: note: template argument deduction/substitution failed:</div><div>SNAPLib/SortedDataWriter.cpp:339:86: note: deduced conflicting types for parameter 'const _Tp' ('long long unsigned int' and '_int64 {aka long long int}')</div><div> min(UINT64_C(1) << 23, max(UINT64_C(1) << 17, bufferSpace / blocks.size()))); // 128kB to 8MB buffer space per block</div><div> ^</div><div><builtin>: recipe for target 'SNAPLib/SortedDataWriter.o' failed</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Jan 23, 2016 at 12:51 AM Aaron M. Ucko <<a href="mailto:ucko@debian.org">ucko@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Source: snap-aligner<br>
Version: 0.18~1.0~beta.18+dfsg1-1<br>
Severity: important<br>
Justification: fails to build from source<br>
<br>
32-bit builds of snap-aligner that get past #812376 still fail:<br>
<br>
SNAPLib/SortedDataWriter.cpp:338:70: error: no matching function for call to 'max(long unsigned int, _int64)'<br>
min(1UL << 23, max(1UL << 17, bufferSpace / blocks.size()))); // 128kB to 8MB buffer space per block<br>
<br>
So far, this error has only occurred on x32, but I expect *i386<br>
builds will fail the same way. I'd suggest including <stdint.h> and<br>
substituting UINT64_C(1) for both occurrences of 1UL here. Could you<br>
please take a look?<br>
<br>
Thanks!<br>
<br>
_______________________________________________<br>
Debian-med-packaging mailing list<br>
<a href="mailto:Debian-med-packaging@lists.alioth.debian.org" target="_blank">Debian-med-packaging@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging" rel="noreferrer" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging</a><br>
</blockquote></div></div></div><div dir="ltr">-- <br></div><div dir="ltr"><span style="color:rgb(34,34,34);font-family:'courier new',monospace;font-size:small;line-height:normal">Michael R. Crusoe CWL Community Engineer </span><a href="mailto:mcrusoe@msu.edu" target="_blank" style="color:rgb(17,85,204);font-family:'courier new',monospace;font-size:small;line-height:normal">crusoe@ucdavis.edu</a><br style="color:rgb(34,34,34);font-family:'courier new',monospace;font-size:small;line-height:normal"><span style="color:rgb(34,34,34);font-family:'courier new',monospace;font-size:small;line-height:normal">Common Workflow Language project University of California, Davis</span><br style="color:rgb(34,34,34);font-family:'courier new',monospace;font-size:small;line-height:normal"><a href="https://impactstory.org/MichaelRCrusoe" target="_blank" style="color:rgb(17,85,204);font-family:'courier new',monospace;font-size:small;line-height:normal">https://impactstory.org/MichaelRCrusoe</a><font size="2" style="color:rgb(34,34,34);font-family:'courier new',monospace;font-size:small;line-height:normal"> <a href="http://twitter.com/biocrusoe" target="_blank" style="color:rgb(17,85,204)">http://twitter.com/biocrusoe</a></font><br></div>