<p>When I was doing the windows port a huge number of bcftools failures were down to variation in the last digit of a floating point number - ie rounding differences. I haven't looked at this particular issue, but we really need a more robust comparison mechanism to determine equality.</p>
<p>The other thing we need to be careful of is assuming zlib. There are many equally valid deflate streams, but IIRC using say the intel deflate causes the test harness to fail too.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you authored the thread.<br />Reply to this email directly, <a href="https://github.com/samtools/bcftools/issues/720#issuecomment-350715163">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJAqA6WtQo24kQ8xunfZiRGXshzk0Z0nks5s_STegaJpZM4Q9TnW">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJAqA65ik-PLFeMnVMOh2EOmDEX5tPZaks5s_STegaJpZM4Q9TnW.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/samtools/bcftools/issues/720#issuecomment-350715163"></link>
<meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/samtools/bcftools","title":"samtools/bcftools","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/samtools/bcftools"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jkbonfield in #720: When I was doing the windows port a huge number of bcftools failures were down to variation in the last digit of a floating point number - ie rounding differences. I haven't looked at this particular issue, but we really need a more robust comparison mechanism to determine equality.\r\n\r\nThe other thing we need to be careful of is assuming zlib. There are many equally valid deflate streams, but IIRC using say the intel deflate causes the test harness to fail too."}],"action":{"name":"View Issue","url":"https://github.com/samtools/bcftools/issues/720#issuecomment-350715163"}}}</script>