<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Dear Andreas,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thank you so much for all your comments! I confirm i pushed the changelog entry , i hope i did it right ;)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I would love to go on with adding an autopkgtest to another package, i was thinking to continue with rsem (n.<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890782" target="_blank">890792</a> ), if that is ok for everyone!<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I would also kindly like to express my interest to apply to either outreachy or GSoC. I had a look to the Outreachy announcement for this round of applications and as i did not see any proposed project by the debian med team (especially the one about adding autopkgtest suites), i was thinking about the GSoC as an alternative. As my PhD thesis will be ready in the end of March but i will still be a student until the beginning of June, i was thinking if it would be possible for me to apply.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Anyway, apart of the internships, i would like to continue contributing to the debian med project , it is a truly unique experience!</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thank you so much again for all the help and comments!</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Kind regards,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Kate</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 19, 2018 at 11:01 AM, Andreas Tille <span dir="ltr"><<a href="mailto:andreas@an3as.eu" target="_blank">andreas@an3as.eu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dear Kate,<br>
<span class=""><br>
On Mon, Feb 19, 2018 at 12:21:35AM +0200, Kalou.Katerina wrote:<br>
> Thank you for your comments!! I tried to push the files again , i think<br>
> that now it worked :)<br>
<br>
</span>I confirm the push worked now. I've pushed some more commits - partly<br>
related to your work. Please keep on reading my comments below.<br>
<span class=""><br>
> > > Any<br>
> > > comments and corrections will be much welcome!! In my linux machine the<br>
> > > 'autopkgtest -- null' command reports a pass.<br>
> > ><br>
> > > In the example folder i have put two sample data that i managed to found<br>
> > at<br>
> > > '<a href="https://github.com/arq5x/bedtools2" rel="noreferrer" target="_blank">https://github.com/arq5x/<wbr>bedtools2</a>'. These two files are '.BED' file<br>
> > > extensions. The example at the macs package install instructions is using<br>
> > > the 'BAM' extension , if anyone has any recommendation on where to find<br>
> > > these, it will be much appreciated!! :)<br>
> ><br>
> > In any case make sure you document the origin of the example filese in<br>
> > debian/README.source (may be you add your question also in this file).<br>
<br>
</span>I've seen you have give some (rather vague) pointer in README.test<br>
(which is fine - no need to create an extra README.source. Besides the<br>
fact that all Debian related stuff needs to be in debian/ dir (I just<br>
moved the file) I wished you would add some more specific pointer. The<br>
best thing would be something like<br>
<br>
wget URL_to_example_file1<br>
wget URL_to_example_file2<br>
<br>
So everybody can immediately reproduce what you did to get the files.<br>
To express what I mean I did so in the latest commit. I also left the<br>
files compressed as downloaded which requires an extra file<br>
<br>
debian/source/include-binaries<br>
<br>
(dpkg-buildpackage will tell you about this so this is no knowledge you<br>
need to keep by heart. ;-) )<br>
<br>
Regarding how to get BAM files instead of BED files I'm hoping for<br>
comments here on the list but for the moment macs2 seems to do something<br>
sensible which should qualify for a first test.<br>
<span class=""><br>
> > > Finally , i included the files 'README.test',<br>
> > 'macs-example-data.install'<br>
<br>
</span>The file macs-example-data.install is wrong. In the other package you<br>
worked on we have created an extra data package. I do not think that<br>
the amount of extra data in the macs example rectifies an additional<br>
package and thus we have no such package macs-example-data defined in<br>
debian/control. Thus this file is simply ignored. You rather need to<br>
put files in debian/macs.examples (and make sure those files are really<br>
existing - since I bumped debian/compat in some unrelated change<br>
mentioning non-existing files has lead to build problems).<br>
<span class=""><br>
> > > and 'macs.install', taking inspiration from the previous packages like<br>
> > > rapmap i worked on. The purpose was to send the examples folder to the<br>
> > > 'usr/share/doc' directory during installation , i do not know if i did it<br>
> > > right!<br>
<br>
</span>I've now fixed it - please check all my according commits.<br>
<br>
Finally please always add a changelog entry to the package documenting<br>
your changes. I'd recommen to use the dch tool for this. For instance<br>
you can do<br>
<br>
dch --team "Add autopkgtest (Closes: #879622)"<br>
<br>
specifically the "Closes:" is important to automatically close the bug.<br>
(You can also use `dch --team` and add the string manually with the<br>
editor.)<br>
<br>
I would like you to take over the changelog entry (that's why the --team<br>
option - see `man dch`) since I want to give credit to the person who<br>
has written the test and has fixed the bug.<br>
<br>
I think the package is ready once you have done the changelog entry and<br>
I'll upload once I have seen your commit. Yesterday I added a set of<br>
new bugs for packages in need of an autopkgtest. So there is a plenty<br>
to pick from and as I wrote here before I issued an according GSoC<br>
project proposal (which can be also picked for outreachy as far as I<br>
know).<br>
<br>
Kind regards<br>
<span class="HOEnZb"><font color="#888888"><br>
Andreas.<br>
<br>
--<br>
<a href="http://fam-tille.de" rel="noreferrer" target="_blank">http://fam-tille.de</a><br>
<br>
</font></span></blockquote></div><br></div>