[Debian-mobcom-maintainers] Bug#1136546: osmo-bts uses pidof but does not depend on procps

[Gioele Barabucci]

Source: osmo-bts
Version: 1.9.0+dfsg1-2
Usertags: pidof-without-procps

Dear maintainer(s) of osmo-bts,

it appears that osmo-bts uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of osmo-bts
  that use `pidof` at runtime;
* via the `Build-Depends:` field of osmo-bts, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of osmo-bts, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that osmo-bts uses `pidof` due to the following
code snippets:

```
path: osmo-bts_1.9.0+dfsg1-2/src/osmo-bts-lc15/misc/lc15bts_bts.c
	/* check for BTS is still alive */
	if (system("pidof osmo-bts-lc15 > /dev/null")) {
		LOGP(DTEMP, LOGL_DEBUG,"BTS process has stopped\n");
		led[BLINK_PATTERN_INT_PROC_MALFUNC] = 1;


path: osmo-bts_1.9.0+dfsg1-2/src/osmo-bts-oc2g/misc/oc2gbts_bts.c
	/* check for BTS is still alive */
	if (system("pidof osmo-bts-oc2g > /dev/null")) {
		LOGP(DTEMP, LOGL_DEBUG,"BTS process has stopped\n");
		led[BLINK_PATTERN_INT_PROC_MALFUNC] = 1;
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci