[Debian-on-mobile-maintainers] [Git][DebianOnMobile-team/chatty][upstream/latest] 104 commits: new-chat-dialog: Inform user if contacts app failed to open

Evangelos Ribeiro Tzaras gitlab at salsa.debian.org
Thu Oct 29 17:52:03 GMT 2020

Evangelos Ribeiro Tzaras pushed to branch upstream/latest at Debian On Mobile / chatty

4d11fd70 by Mohammed Sadiq at 2020-07-14T15:49:38+05:30
new-chat-dialog: Inform user if contacts app failed to open

Fixes #249

- - - - -
990a8977 by Luís Fernando Stürmer da Rosa at 2020-07-15T20:02:50+00:00
Update pt_BR.po
- - - - -
c716e02f by Guido Günther at 2020-07-21T13:18:23+00:00
data: Drop unused protocol icons

We can bring them back if needed.

Closes: #374

- - - - -
8285292f by Daniel Șerbănescu at 2020-07-21T13:55:19+00:00
po: Update Romanian translation

- - - - -
9328cb28 by Luís Fernando Stürmer da Rosa at 2020-07-30T11:37:24-03:00
po: Update Brazilian Portuguese translation

Signed-off-by: Rafael Fontenelle <rafaelff at gnome.org>

- - - - -
475eb4f2 by Yuri Chornoivan at 2020-07-31T12:48:20+00:00
po: Update Ukrainian translation

- - - - -
a1f49014 by Daniel Mustieles at 2020-07-31T18:52:40+05:30
po: Update Spanish translation

See https://source.puri.sm/Librem5/chatty/-/issues/384

- - - - -
6dd3dc72 by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
tests: Add direct database tests for history

So that we can ensure that database isn’t broken regardless
of the code changes.

- - - - -
afcadfaa by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
meson: Move chatty-message to libsrc

So that it can be used in tests

- - - - -
dbfccafd by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
message: Add API to get/set custom name

- - - - -
e204078a by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
chat: Add API to get chat name

- - - - -
6294dda9 by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
chat: Add API to prepend message

- - - - -
db689dba by Mohammed Sadiq at 2020-08-05T21:08:43+05:30
chat: Add API to check if chat is IM

- - - - -
a107ab41 by Mohammed Sadiq at 2020-08-06T13:56:31+05:30
Add and use new history

This is pretty much a complete rewrite moving all database actions to
a separate thread.

Fixes #323 #353

- - - - -
ec4ae8f7 by Mohammed Sadiq at 2020-08-06T14:45:47+05:30
window: Use GtkStack to stack sidebar widgets

Fixes #244

- - - - -
ecbc84d9 by Mohammed Sadiq at 2020-08-06T18:20:07+05:30
window: Simplify updating headerbar info button

- - - - -
18212fcd by Evangelos Ribeiro Tzaras at 2020-08-06T22:04:09+02:00
src/chatty-manager.c: Fix spelling mistake

Fixes lintian information: spelling-error-in-binary

- - - - -
3eec20e7 by Evangelos Ribeiro Tzaras at 2020-08-07T12:42:45+02:00
Desktop files: Add "Network" main category

Fixes lintian warning desktop-entry-lacks-main-category

- - - - -
e5e1cfa3 by Mohammed Sadiq at 2020-08-07T16:27:39+05:30
chat-view: Focus chat entry when mapped

Let's focus the entry when mapped and so we don't have to handle
this outside of chat-view.

- - - - -
ed7e5488 by Mohammed Sadiq at 2020-08-07T18:47:56+05:30
chat: Add 'buddy-typing' property and use it

So that we can update chat-view widgets based on the property
instead of letting other classes do it.

- - - - -
19b181b7 by Mohammed Sadiq at 2020-08-08T21:21:24+05:30
chat-view: Clear related hash table data on finalize

Do it in chat-view instead of manager, so that we can avoid
a public API

- - - - -
74e10a6b by Mohammed Sadiq at 2020-08-10T17:13:58+05:30
Reduce usage of chatty_conversation

We eventually want to remove this variable so that ui_data can
be reused for saving associated GObject

- - - - -
9823231c by Emin Tufan Çetin at 2020-08-10T12:01:32+00:00
po: Update Turkish translation
- - - - -
53ce7e8f by Mohammed Sadiq at 2020-08-10T14:48:54+00:00
notify: Remove unused code

This code is never run

- - - - -
30765af6 by Zander Brown at 2020-08-10T19:48:18+00:00
po: Update British English translation
- - - - -
f401634d by Mohammed Sadiq at 2020-08-11T05:22:33+00:00
list-row: Add some translation comments

- - - - -
c61eb171 by Mohammed Sadiq at 2020-08-11T16:02:21+05:30
purple-notify: Place dialog over the current active window

Use the current active window instead of placing on top of the main window.
The main window is not always required to be the active one.  Also avoid
the cast as the window may be NULL if no window is present

- - - - -
766bb22f by Mohammed Sadiq at 2020-08-11T17:49:56+05:30
manager: Move buddy-icon-changed from conversation

- - - - -
86cc25fb by Mohammed Sadiq at 2020-08-12T14:00:10+05:30
muc-info-dialog: Use chatty-chat API to set notifications

- - - - -
d5602126 by Mohammed Sadiq at 2020-08-12T14:00:20+05:30
user-info-dialog: Use chatty-chat API to set notifications

- - - - -
0735ab18 by Mohammed Sadiq at 2020-08-12T09:11:16+00:00
window: Use chatty-chat APIs where possible

- - - - -
bd85a4ac by Mohammed Sadiq at 2020-08-12T17:10:05+05:30
window: Simplify getting current chat

- - - - -
abd802c8 by Mohammed Sadiq at 2020-08-12T19:25:29+05:30
window: Simplify setting item

Don’t duplicate the same code everywhere

- - - - -
e673a2fb by Mohammed Sadiq at 2020-08-12T20:10:53+05:30
chat: Implement set_avatar_async

- - - - -
e070708c by Mohammed Sadiq at 2020-08-12T20:11:11+05:30
user-info-dialog: Use chatty-item API to set avatar

- - - - -
07aa460a by Mohammed Sadiq at 2020-08-12T20:27:43+05:30
user-info-dialog: Simplify check if chat is IM

- - - - -
f4c2e3c9 by Mohammed Sadiq at 2020-08-12T22:40:00+05:30
chat: Add API to get associated chaty-account

- - - - -
8ee3bbe7 by Mohammed Sadiq at 2020-08-12T22:40:18+05:30
window: Simplify filtering chat list

- - - - -
644ee26e by Mohammed Sadiq at 2020-08-13T14:51:42+05:30
Add API to get active chat and use it

- - - - -
7dcc906c by Mohammed Sadiq at 2020-08-13T17:01:34+05:30
manager: Add chat-deleted signal and use it

items-changed signal is emitted after the item is removed from the list.
If the removed item is selected_item, it may have already freed.  So the
CHATTY_IS_CHAT (selected_item) is invoking a UB.  Let's fix it.

- - - - -
48c3703b by Mohammed Sadiq at 2020-08-14T17:53:18+05:30
manager: Add open-chat signal and use it

This will help us dissociate libpurple handling UI and isolate
UI code from program logic.

- - - - -
eb85ddb9 by Mohammed Sadiq at 2020-08-14T18:47:15+05:30
Remove no longer required code

- - - - -
b19f9aa8 by Mohammed Sadiq at 2020-08-14T19:11:31+05:30
Simplify showing a conversation

purple_conversation_present() does all what we need, use that.
Don't repeat them.

- - - - -
3fb670ae by Mohammed Sadiq at 2020-08-15T13:22:13+05:30
application: Show main window on clicking notification

- - - - -
2911bea4 by Mohammed Sadiq at 2020-08-15T08:14:36+00:00
chat-view: Replace purple APIs with chatty-chat APIs

- - - - -
b9f8657e by Zander Brown at 2020-08-15T08:55:27+00:00
l10n: disambiguate timestamp strings

This is the same change we made in phosh


- - - - -
88f40a9e by Zander Brown at 2020-08-15T08:55:27+00:00
utils: improve translation of timestamps on messages

- - - - -
ca7da7ce by Mohammed Sadiq at 2020-08-17T11:23:02+05:30
window: Always reset unread count after opening a chat

Currently, the count is reset only when switching the chat page.
But if the previously selected chat is the same as the currently
selected one, the count isn't reset (as no switching happened)

Fixes #387

- - - - -
35b3d1ae by Mohammed Sadiq at 2020-08-19T17:52:01+05:30
window: Don't change selection when fold mode changes

When the window style changes from folded mode to non-folded mode,
the first chat list item is selected by default regardless of the
current state.

Instead of blindly selecting the first item, select the first item
only if none is selected when window changes to non-folded mode.

- - - - -
18c0f8f1 by Mohammed Sadiq at 2020-08-19T16:24:19+00:00
history: Fix possible deadlock

history is a singleton object.  It's created and finalized only once in
an application's lifetime.  But in tests, the same object may be reused
after closing database, which can result in races that lock the GTask to
never complete.

Free object data in dispose and explicitly run dispose when the database
is closed so that we don't have wait for GObject to free data which may
be delayed.

- - - - -
98f3a18b by Mohammed Sadiq at 2020-08-19T16:24:19+00:00
history: Close database right

We were always passing NULL as db

- - - - -
129bb80d by Yuri Chornoivan at 2020-08-20T03:50:13+00:00
po: Update Ukrainian translation
- - - - -
e19581c0 by Mohammed Sadiq at 2020-08-20T04:02:22+00:00
chat: Add API to delete chat and use it

Move Purple API to delete a chat to chatty-chat use that API
to delete a chat.

- - - - -
6eaf1156 by Mohammed Sadiq at 2020-08-20T14:40:32+05:30
Release version 0.1.15

- - - - -
23b3c226 by Mohammed Sadiq at 2020-08-20T15:47:30+05:30
window: Set popover relative-to in UI file

- - - - -
10cc19e9 by Mohammed Sadiq at 2020-08-20T15:55:21+05:30
window: Simplify handling add chat

There is no reason to use bit twiddling here.

- - - - -
ce43aa2d by Mohammed Sadiq at 2020-08-21T10:09:40+05:30
Remove ChattyConversation struct

And reuse conv->ui_data for saving associated ChattyChat.

- - - - -
0e60e2b9 by Mohammed Sadiq at 2020-08-21T16:11:20+05:30
chat: Fix possible dereferencing of NULL

- - - - -
b1cf8a8b by Mohammed Sadiq at 2020-08-21T16:13:43+05:30
chat: Simplify setting PurpleConversation

Don't duplicate code.

- - - - -
7784b9a4 by Mohammed Sadiq at 2020-08-21T16:52:10+05:30
chat: Remove purple-chat property

It's valid for a chat to not have a PurpleChat.  Also, we don't use
purple-chat property to set PurpleChat when creating an object from

So Let's simply use direct pointer assignment instead of a property
so that we can have less code.

- - - - -
f3298f9a by Mohammed Sadiq at 2020-08-21T17:10:40+05:30
chat: Point ui_data to self when setting PurpleChat

Currently `ui_data` variable is not used.  Let's use it
so that we can eventually remove some list models to handle
chat list.

- - - - -
cdd401a9 by Mohammed Sadiq at 2020-08-21T17:51:37+05:30
chat: Simplify setting buddy

Code for setting buddy were duplicated.  Put
them into a function and use that.

- - - - -
01703a45 by Mohammed Sadiq at 2020-08-24T16:14:08+05:30
manager: Remove redundant code

"conversation-created" and "chat-joined" signals are emitted
immediately after the conversation is created.

When the conversation is created, it is handled by chatty_conv_new(),
which adds the PurpleConversation to the chat list.  So what ever
"conversation-created" and "chat-joined" callbacks where doing are
already done by chatty_conv_new().  So let's remove these signals
and their handlers as nothing is done there.

- - - - -
ba21113f by Mohammed Sadiq at 2020-08-24T16:14:08+05:30
utils: Remove an unused function

- - - - -
6e528af0 by Mohammed Sadiq at 2020-08-27T18:32:53+05:30
chat-view: Don't let Return key insert newline if set to send message

If Return key press is set to send the inserted message, never insert
a newline when the key is pressed.

This was happening when the message input is empty and thus the Return
key press wasn't claimed to send the message.

If Return key is pressed with the message input empty, do an arror bell

Fixes #391

- - - - -
404fd8ba by Mohammed Sadiq at 2020-08-27T19:16:59+05:30
Move chatty-conversation to chatty-manager

Move all chatty-conversation code to chatty-manager so that we
are closer to the plan to make manager alone deal with libpurple

- - - - -
ce0088a1 by Mohammed Sadiq at 2020-08-27T19:37:02+05:30
window: Use chatty-item API to check if item is SMS

- - - - -
0c469ce8 by Mohammed Sadiq at 2020-08-27T19:37:53+05:30
manager: Remove unused function

- - - - -
d3aeb67c by Mohammed Sadiq at 2020-08-28T15:11:22+05:30
chat: Fix setting ui_data when buddy/chat is already set

If ChattyChat has a PurpleBuddy or PurpleChat already set,
the `ui_data` of the PurpleConversation wasn't updated
when a conv is set for the chat.

So instead, check for PurpleBuddy/PurpleChat after the `ui_data'
is updated.  Also, remove previously set `ui_data` for the conv
already set in the chat, if any.

- - - - -
64b19bca by Mohammed Sadiq at 2020-08-28T16:20:58+05:30
manager: Add chat to the right store

We were blindly adding all chats to im_list.  Let's check
the chat type and add chat to the appropriate list.

- - - - -
81b5c71c by Mohammed Sadiq at 2020-08-28T17:50:43+05:30
chat: Link buddy to self when buddy is set

This can be useful to get the IM chat of a buddy if it
exists.  Currently we use a liststore to do so, which
shall be removed soon.

- - - - -
8acb9915 by Mohammed Sadiq at 2020-08-31T14:41:34+05:30
manager: Unset buddy chat when deleting a chat

- - - - -
07c01ef5 by Mohammed Sadiq at 2020-08-31T14:41:34+05:30
manager: Check if chat exists before adding a new one

- - - - -
31bce93a by Mohammed Sadiq at 2020-08-31T18:55:47+05:30
chat: Destroy conversation when deleting chat

Otherwise the chat is simply destroyed, but the user is not left
from the active conversation, if any.  purple_conversation_destroy()
shall do that.

- - - - -
b9505127 by Mohammed Sadiq at 2020-08-31T20:29:45+05:30
new-chat-dialog: Hide chats from disconnected accounts

- - - - -
5b02437c by Mohammed Sadiq at 2020-08-31T20:29:45+05:30
manager: Don't remove chat when node is removed

libpurple may remove a node to simply add it again. It's hard
to know if the removal happened simply to add it again or not.

When an actual deletion happen, the associated PurpleConversation
is deleted, and so tracking PurpleConversation alone can make this
process simpler.

- - - - -
ab065cd5 by Mohammed Sadiq at 2020-08-31T20:34:08+05:30
manager: Remove no longer used code

- - - - -
b8cf9474 by Mohammed Sadiq at 2020-09-01T16:22:04+05:30
manager: Simplify adding chat to list

Use chatty_manager_add_chat() instead of chatty_manager_add_conversation()
So that we have one less API. Also add_chat() adds chat to the right
list instead of blindly adding to im_list, which was how it was done
until now.

- - - - -
3fb9c1a7 by Mohammed Sadiq at 2020-09-01T16:22:53+05:30
manager: Remove no longer used function

- - - - -
5e07a9b6 by Mohammed Sadiq at 2020-09-01T17:09:38+05:30
chat-view: Use an array to store emoticons

So that we don't have to handle memory [de]allocations.

- - - - -
2638c04b by Mohammed Sadiq at 2020-09-01T18:58:32+05:30
chat: Use the right variable for check

We were using the wrong variable to check for match
resulting in surprising results

- - - - -
0dd3fad1 by Mohammed Sadiq at 2020-09-02T15:46:20+05:30
manager: Use chatty-item API to get chat protocol

- - - - -
5b69c8aa by Mohammed Sadiq at 2020-09-02T15:46:56+05:30
pp-account: Use chatty-item API to get protocol

- - - - -
06e1dec6 by Mohammed Sadiq at 2020-09-02T15:47:32+05:30
settings-dialog: Use chatty-item API to get protocol

- - - - -
c4e0cb84 by Mohammed Sadiq at 2020-09-02T15:48:18+05:30
new-muc-dialog: Use chatty-item API to get account protocol

- - - - -
3546263c by Mohammed Sadiq at 2020-09-02T15:48:52+05:30
chat-view: Use chatty-item API to get chat protocol

- - - - -
db168b4b by Mohammed Sadiq at 2020-09-02T15:49:31+05:30
pp-buddy: Use chatty-item API to get buddy protocol

- - - - -
04cffa54 by Mohammed Sadiq at 2020-09-02T19:43:32+05:30
new-chat-dialog: Hide IM chats with buddies

We don't have to list IM chats as buddies are listed separately

- - - - -
e1612425 by Mohammed Sadiq at 2020-09-02T19:55:44+05:30
manager: Remove some lists used to store chats

We now make use of ui_data for tracking various objects.  And
so we no longer have to lookup in lists to find the objects.

Don't differentiate between IM and chats.  Use a single liststore
for any type of chats, and so we no longer require im_list, and
related helper models.

- - - - -
59465742 by Mohammed Sadiq at 2020-09-02T19:58:02+05:30
manager: Rename a variable

Use sorted_chat_list, which is now more appropriate.

- - - - -
81b394c9 by Mohammed Sadiq at 2020-09-02T21:06:30+05:30
manager: Use ui_data to get chat from conv

- - - - -
af180180 by Mohammed Sadiq at 2020-09-02T21:06:30+05:30
xep-0184: Use ui_data to get chat from conv

- - - - -
4a2d9dd1 by Mohammed Sadiq at 2020-09-02T21:06:30+05:30
muc-info-dialog: Use ui_data to get chat from conv

- - - - -
957eecda by Mohammed Sadiq at 2020-09-02T21:06:30+05:30
manager: Remove an unused function

- - - - -
6b31ce6c by Fabio Tomat at 2020-09-07T19:26:53+00:00
po: Add friulian to LINGUAS
- - - - -
9d49e6a9 by Fabio Tomat at 2020-09-07T19:28:14+00:00
po: Add friulian translations
- - - - -
228b4cfb by Mohammed Sadiq at 2020-09-14T12:11:10+00:00
Add chatty-chat base class

And move the old chatty-chat to chatty-pp-chat

So that we can use this as the base class for chats

- - - - -
f122ab12 by Mohammed Sadiq at 2020-09-14T19:55:33+05:30
item: Move is_sms() from chatty-pp-account

And adapt to API changes.

chatty_pp_account_is_sms() was using only chatty-item API.
So moving it to chatty-item shall allow us to use the API
in more cases, and not just for accounts

- - - - -
c41f9258 by Mohammed Sadiq at 2020-09-14T19:55:33+05:30
account: Move some pp-account APIs to parent class

So that it can be used for all type of accounts

- - - - -
bbe4ab96 by Mohammed Sadiq at 2020-09-16T20:56:47+05:30
account: Move more APIs from pp-account

And adapt to API changes

- - - - -
80f527a3 by scootergrisen at 2020-09-17T11:18:21+00:00
Update da.po
- - - - -
de0df95f by Anders Jonsson at 2020-09-18T12:27:30+00:00
Add Swedish translation

- - - - -
bee7e617 by Марко Костић (Marko Kostić) at 2020-09-23T05:42:28+00:00
po: Add Serbian translation

- - - - -
d6ffe9de by Mohammed Sadiq at 2020-09-23T13:15:50+05:30
Release version 0.1.16

- - - - -

16 changed files:

- − data/icons/protocol/Matrix_logo.svg
- − data/icons/protocol/Telegram_logo.png
- − data/icons/protocol/XMPP_logo.svg
- data/sm.puri.Chatty-daemon.desktop.in
- data/sm.puri.Chatty.desktop.in
- debian/changelog
- debian/control
- meson.build
- po/POTFILES.in
- po/da.po
- po/en_GB.po
- po/es.po
- + po/fur.po
- po/pt_BR.po
- po/ro.po

The diff was not included because it is too large.

View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/chatty/-/compare/131a193e8d7eb529f5442e9db20390a68c58488f...d6ffe9de39e31d9616924e6eb9df118e8e0575c5

View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/chatty/-/compare/131a193e8d7eb529f5442e9db20390a68c58488f...d6ffe9de39e31d9616924e6eb9df118e8e0575c5
You're receiving this email because of your account on salsa.debian.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20201029/e0c92923/attachment-0001.html>

More information about the Debian-on-mobile-maintainers mailing list