[Debian-on-mobile-maintainers] Bug#1003476: Bug#1003476: libomemo cross misbuilds

[Helmut Grohne]

On Tue, Jan 11, 2022 at 12:57:59AM +0100, Evangelos Ribeiro Tzaras wrote:
> This confused me for a moment (in fact I wondered if it shouldn't be
> the other way around), because I naively misunderstood the meaning of
> "build" (as in the architecture for which to build) and "host" (as in
> the host I'm building on), but after looking it up [1] it makes a lot
> more sense ;)

You're not the only one who is confused by the terminology. Over time,
one can get used to it.

> Out of curiosity: That patch works because in a cross compilation CC
> will f.e. be aarch64-linux-gnu-gcc because that is set via the included
> /usr/share/dpkg/buildtools.mk, right?

Correct explanation. dh_auto_build will also set CC, but not
dh_auto_install (which is the relevant part here).

> Initially I contemplated including /usr/share/dpkg/architecture.mk and
> somehow using DEB_TARGET_GNU_TYPE, but your patch seems much cleaner,
> so thanks a lot!

Rule of thumb: target is never right tool (unless you know it is).

> Since this actually issue came up [2] some time ago upstream and the 
> $(CC) bit could go there, do you want to submit this part of the patch
> or should I do this (preserving your authorship of course!)?

Yes please (regardless of the authorship). Let's just make it work. To
me this is one in >2000 patches. A drop in the bucket.

Helmut