[Debian-on-mobile-maintainers] Bug#1016146: osk-sdl: Physical keypresses visible on console after exiting

[Benjamin Moody]

Package: osk-sdl
Version: 0.67-1
Severity: normal
Tags: patch
X-Debbugs-Cc: benjamin.moody at gmail.com

Dear Maintainer,

If osk-sdl is invoked from initramfs via 'osk-sdl-keyscript', and I
enter the passphrase using the *physical* keyboard, the keys I press
are echoed on the Linux console and are visible after osk-sdl exits.

(This is separate from the fact that osk-sdl itself logs hardware
keypresses when invoked with -v, which is a problem with the keyscript
in version 0.61.1-2 but has been fixed in 0.67-1.)

This appears to be a known bug in SDL
(https://github.com/libsdl-org/SDL/issues/2418); it's not clear to me
if this is somehow device-dependent.

A workaround is to do this:

--- osk-sdl-0.67/debian/initramfs/scripts/osk-sdl-keyscript
+++ osk-sdl-0.67/debian/initramfs/scripts/osk-sdl-keyscript
@@ -9,7 +9,13 @@
 
 plymouth hide-splash 2>/dev/null
 
+ttymode=$(stty -g)
+stty -echo -icanon min 0 time 0
+
 /usr/bin/osk-sdl -k -d "${CRYPTTAB_SOURCE}" -n "${CRYPTTAB_NAME}" -c /etc/osk.conf
 
+cat >/dev/null
+stty "$ttymode"
+
 plymouth show-splash 2>/dev/null
 

(Tested by rebuilding osk-sdl 0.67-1 on bullseye.)

'scripts/local-top/osk-sdl' probably has the same problem (as well as
the -v issue); I haven't tried it.

-- System Information:
Debian Release: 11.4
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.0-16-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages osk-sdl depends on:
ii  cryptsetup            2:2.3.7-1+deb11u1
ii  cryptsetup-initramfs  2:2.3.7-1+deb11u1
ii  fonts-dejavu-core     2.37-2
ii  libc6                 2.31-13+deb11u3
ii  libcryptsetup12       2:2.3.7-1+deb11u1
ii  libegl1               1.3.2-1
ii  libgcc-s1             10.2.1-6
ii  libgl1                1.3.2-1
ii  libgles2              1.3.2-1
ii  libsdl2-2.0-0         2.0.14+dfsg2-3+deb11u1+bm1
ii  libsdl2-ttf-2.0-0     2.0.15+dfsg1-1
ii  libstdc++6            10.2.1-6

osk-sdl recommends no packages.

osk-sdl suggests no packages.

-- no debconf information