[Debian-on-mobile-maintainers] [Git][DebianOnMobile-team/phoc][debian/master] 2 commits: d/patches: backport upstream patch fixing crash in touch handling

[Guido Günther (@agx)]

Guido Günther pushed to branch debian/master at Debian On Mobile / phoc


Commits:
3ac60890 by Arnaud Ferraris at 2022-06-03T13:25:52+02:00
d/patches: backport upstream patch fixing crash in touch handling

- - - - -
2327489b by Arnaud Ferraris at 2022-06-03T13:26:51+02:00
d/changelog: release version 0.20.0-2

- - - - -


3 changed files:

- debian/changelog
- + debian/patches/0001-cursor-avoid-NULL-pointer-dereference.patch
- + debian/patches/series


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,18 @@
+phoc (0.20.0-2) unstable; urgency=medium
+
+  [ Guido Günther ]
+  * d/control: Add myself as maintainer.
+    This way I don't have to remember that it's a team upload.
+  * d/copyright: Drop src/ini.*
+    We replaced this with our own parser a while back.
+  * Update d/copyright.
+    We have a new protocol there
+
+  [ Arnaud Ferraris ]
+  * d/patches: backport upstream patch fixing crash in touch handling
+
+ -- Arnaud Ferraris <arnaud.ferraris at gmail.com>  Fri, 03 Jun 2022 13:25:57 +0200
+
 phoc (0.20.0-1) unstable; urgency=medium
 
   [ Arnaud Ferraris ]


=====================================
debian/patches/0001-cursor-avoid-NULL-pointer-dereference.patch
=====================================
@@ -0,0 +1,35 @@
+From: Arnaud Ferraris <arnaud.ferraris at gmail.com>
+Date: Thu, 2 Jun 2022 23:05:59 +0200
+Subject: cursor: avoid NULL pointer dereference
+
+When touching the screen while blanked, phoc receives a `touch_up`
+event, matching a previously discarded `touch_down` event (due to the
+output being disabled).
+
+This leads to a failure to retrieve the touch point while processing
+`touch_up`, ultimately causing a segfault due to a NULL pointer
+dereference.
+
+Properly checking said pointer in order to avoid this crash.
+
+Origin: upstream, https://gitlab.gnome.org/World/Phosh/phoc/-/commit/4601c66b7e3df055ba1f67beaf0dea7b4e817544
+---
+ src/cursor.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/src/cursor.c b/src/cursor.c
+index 49f2f09..cfa36b4 100644
+--- a/src/cursor.c
++++ b/src/cursor.c
+@@ -1030,6 +1030,11 @@ phoc_cursor_handle_touch_up (PhocCursor                *self,
+   PhocTouchPoint *touch_point;
+ 
+   touch_point = phoc_cursor_get_touch_point (self, event->touch_id);
++
++  /* Don't process unknown touch points */
++  if (!touch_point)
++    return;
++
+   handle_gestures_for_event_at (self, touch_point->lx, touch_point->ly,
+                                 PHOC_EVENT_TOUCH_END, event, sizeof (*event));
+   phoc_cursor_remove_touch_point (self, event->touch_id);


=====================================
debian/patches/series
=====================================
@@ -0,0 +1 @@
+0001-cursor-avoid-NULL-pointer-dereference.patch



View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/phoc/-/compare/6cb692f54d7534f2d92426aacb6d558814bb9532...2327489b12dbe2442a0b4c175b351f875853a26a

-- 
View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/phoc/-/compare/6cb692f54d7534f2d92426aacb6d558814bb9532...2327489b12dbe2442a0b4c175b351f875853a26a
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20220604/24f606b3/attachment-0001.htm>