[Debian-on-mobile-maintainers] Bug#1028554: Bug#1028554: osk-sdl: Missing initial configuration

[Undef]

On 1/13/23 03:48, /dev/fra via Debian-on-mobile-maintainers wrote:
>
> After installing osk-sdl I was expecting it to show up automatically at
> the next boot, but that was not the case. I had to edit /etc/crypttab,
> add the option
>
> "keyscript=/usr/share/initramfs-tools/scripts/osk-sdl-keyscript"
>
> and then update initramfs.
>
> Shouldn't this configuration step be performed automatically during the
> installation instead?


Thanks for the bug report.

I'm not sure I'd agree that this is the packages job to configure. In 
#1014393 we decided to remove config automatically, but that was a 
single very specific instance that always leaves the system unbootable.

In this case the package would have to add the config, potentially 
breaking what the user was doing before.

The basic version of this might be `sed -i 
"s:$:keyscript=/usr/share/initramfs-tools/scripts/osk-sdl-keyscript:" 
/etc/crypttab`, but this will break if the user is already using 
keyfiles for example.


If you can think of a robust way of fixing this I'm happy to 
review/include a patch, I just worry that most solutions will break 
existing (and unknown) installs that were already bootable. Any solution 
should also ensure that if it changes the config the debconf flag to 
revert the change is also set.