[Debian-on-mobile-maintainers] Bug#1032914: phog: ships /etc/pam.d/greetd

[Marc Dequènes (duck)]

Quack,

On 2023-03-21 18:49, Arnaud Ferraris wrote:

> @duck, any comment on the above?

Thanks for the contribution.

Honestly when I read the title I really wondered how phog could have 
ended-up shipping this file. I forgot it initially, was asked about it 
and added it quickly, so it's not like I would have rejected the idea.

Anyway, back to the patch itself. First I wonder if it's useful to ship 
the second PAM config since in the code (greetd/src/server.rs#211) it 
simply use the base greetd PAM configuration as a fallback; this is not 
a blocker though.
Then I would prefer if the changelog entries were shipped with the 
corresponding changes and not in a lump afterwards. Also the "debian:" 
and "d/*:" prefixes are not the style I use. Maybe I'm missing why some 
people still use it but with the VCS taking care of remembering which 
files have been changed I don't feel the need to add this anymore and 
it's not very non-DD friendly. I like your comments to clearly explain 
the rationale.

Regards.
\_o<

-- 
Marc Dequènes