[Debian-on-mobile-maintainers] [Git][DebianOnMobile-team/feedbackd][debian/latest] 74 commits: docs: Expand the examples section a bit

Guido Günther (@agx) gitlab at salsa.debian.org
Sun Jun 23 10:44:27 BST 2024



Guido Günther pushed to branch debian/latest at Debian On Mobile / feedbackd


Commits:
945435f0 by Guido Günther at 2024-05-11T13:59:55+02:00
docs: Expand the examples section a bit

- - - - -
eccd95a1 by Guido Günther at 2024-05-11T12:12:14+00:00
Merge branch 'docs' into 'main'

docs: Expand the examples section a bit

See merge request Librem5/feedbackd!121
- - - - -
83f14a45 by Guido Günther at 2024-05-17T06:24:50+00:00
led: Add doc strings

- - - - -
b8718992 by Guido Günther at 2024-05-17T06:24:50+00:00
led: Drop unused variable

- - - - -
973c7e00 by Guido Günther at 2024-05-17T06:24:50+00:00
led: Don't forget to init variable

- - - - -
95c51c02 by Guido Günther at 2024-05-17T06:24:50+00:00
fbd-dev-led-multicolor: Drop unused variable

- - - - -
f6a92231 by Guido Günther at 2024-05-17T06:24:50+00:00
fbd-theme-validate: Use G_NORETURN

- - - - -
a188cdde by Guido Günther at 2024-05-17T06:24:50+00:00
Build: Use meson instead of ninja

- - - - -
2db8e8f8 by Guido Günther at 2024-05-17T06:24:50+00:00
ci: Add clang build

- - - - -
d5b0f302 by Guido Günther at 2024-05-17T06:24:50+00:00
tests: Add umockdev based tests for leds

This ensures we can probe the different led types correctly

The umockdev data was recoreded on an Librem 5 and Librem 14

- - - - -
cfa8e0b2 by Guido Günther at 2024-05-17T06:41:51+00:00
Merge branch 'umockdev' into 'main'

tests: Add umockdev based tests for leds

See merge request Librem5/feedbackd!122
- - - - -
bc0449f7 by Guido Günther at 2024-05-31T15:01:00+02:00
lfb-event: Fix typo in docstring

Gbp-Dch: Ignore

- - - - -
d4d1796c by Guido Günther at 2024-05-31T13:17:25+00:00
Merge branch 'doc-fix' into 'main'

lfb-event: Fix typo in docstring

See merge request Librem5/feedbackd!123
- - - - -
66b61667 by Dylan Van Assche at 2024-06-07T10:14:45+02:00
fbd-dev-led-multicolor: Use separate log domain

Debugging driver probing is much easier when each driver has its own log domain.

- - - - -
7f69813e by Dylan Van Assche at 2024-06-07T10:15:30+02:00
fbd-dev-led-multicolor: Fix typo in error message

multicololo -> multicolor LED

- - - - -
94afe719 by Dylan Van Assche at 2024-06-07T10:15:39+02:00
fbd-dev-led: Scan for RGB color as well

Multicolor LEDs have the color 'rgb', we should also scan it
as they are also a FbdDevLed.

- - - - -
bcd37b0a by Dylan Van Assche at 2024-06-09T11:18:09+02:00
fbd-dev-led-*: Adjust to method convention

fbd_dev_led_ is the convention for methods, adjust them all.

- - - - -
e43126b0 by Dylan Van Assche at 2024-06-09T11:21:19+02:00
fbd-dev-led: Rework color API

Drop has_color API since supported colors are set during probing
and can be handled completely separately from the classes for
each type of hardware.

Rename set_color to set_supported_color because the usage
of this API is to check if the color is supported, but not
setting it. Setting the color is also separated from
start_periodic API to re-use multicolor across multiple LED types
with a set_color API. Multicolor LEDs are actually the same as
regular LEDs but they require a few additional sysfs entries to
actually set the color. Single color LEDs only have a single color
so the set_color method just returns TRUE for these LEDs.

Supported colors are advertised through the supports_color API now.
This way, each LED driver define which colors are supported
through supports_color API. RGB multicolor LEDs will report only fixed colors
like red, blue, green and white until the kernel can expose if a diffusor
is present to mix these colors.

- - - - -
63b56449 by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-ledctrl: Set permissions for hw_pattern

Allow access to hw_pattern sysfs node for feedbackd, similar to other nodes.

- - - - -
60ce9ecb by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-dev-led: Check max_brightness_percentage range

Percentages are always between 0.0 and 100.0.
Also fix a typo along the way.

- - - - -
22e4c336 by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-dev-led-multicolor: Support red, green, blue and white LED colors

Provide our own supports_color method to specify which colors are
actually implemented by the driver. RGB LEDs could provide different
colors as well such as orange, purple, etc. but those are not supported
yet.

- - - - -
10e6d3cb by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-dev-led-qcom: Support QCOM LPG LED single color

QCOM LPG LEDs expose a hw_pattern sysfs entry which accepts a limited
set of patterns but allows to use dedicated hardware for blinking the
LED. This way, battery life can be improved and the LED still blinks,
even if the device is suspended.

- - - - -
2b53725f by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-dev-led-qcom-multicolor: Support QCOM LPG LED multicolor

QCOM LPG LEDs can also operate in a multicolor fashion.
Re-use the probing sequence of multicolor LEDs and the hw_pattern
configuration of single color QCOM LPG LEDs.

- - - - -
6b1eb92b by Dylan Van Assche at 2024-06-09T11:21:20+02:00
fbd-dev-leds: Probe QCOM HW LED types

Try first the QCOM hardware LED types which require the most features of
LED drivers. Try until we have a single color GPIO LED which is the
minimal LED driver support we require. If the LED does not meet that
expectation either, we ignore the LED.

- - - - -
12be49b9 by Guido Günther at 2024-06-09T09:45:20+00:00
Merge branch 'qcom-lpg-hwpattern' into 'main'

fb-dev-leds: support hw_pattern for Qualcomm LPG

See merge request Librem5/feedbackd!100
- - - - -
fcd210ef by Guido Günther at 2024-06-10T10:33:03+02:00
led-qcom: Use char instead of gchar

We prefer the C types in new code.

- - - - -
25585682 by Guido Günther at 2024-06-10T10:33:03+02:00
led-qcom-multicolor: Drop unused defines

- - - - -
f581c158 by Guido Günther at 2024-06-10T10:33:05+02:00
led-qcom-multicolor: Don't leak qcom_led

- - - - -
3c588fdb by Guido Günther at 2024-06-10T15:50:50+02:00
led-qcom: Check for LED driver

The hw_pattern attribute is driver specific. Ensure we don't apply the
LED pattern to unknown drivers.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/77

- - - - -
c3b4877d by Guido Günther at 2024-06-11T07:48:49+00:00
Merge branch 'qcom-lpg' into 'main'

led-qcom: Check for LED driver

Closes #77

See merge request Librem5/feedbackd!124
- - - - -
e9743f3d by Guido Günther at 2024-06-12T16:24:33+02:00
ci: Update common files from meta-phosh

This updates to commit f3c92e90dcc0d65322888217429b75dd101bd0d3

- - - - -
1c51eb20 by Guido Günther at 2024-06-12T16:24:33+02:00
ci: Use common jobs from meta-phosh

- - - - -
a0a0c46a by Guido Günther at 2024-06-13T05:34:39+00:00
Merge branch 'ci' into 'main'

Use shared ci from meta-phosh

See merge request Librem5/feedbackd!127
- - - - -
9aa6696e by Guido Günther at 2024-06-13T07:44:25+02:00
build: Let daemon dependency depend on generated enum headers

Otherwise it might not be available in the tests

- - - - -
6e9e5700 by Guido Günther at 2024-06-13T07:44:34+02:00
dev-led-multicolor: Use correct format specifier

The values are unsigned int

- - - - -
17d91065 by Guido Günther at 2024-06-13T07:44:36+02:00
doc: Document feedback types

This allows us to remove the list from the README

- - - - -
8d4c2590 by Guido Günther at 2024-06-13T07:44:39+02:00
doc: Fix URLs

Don't use Markdown markup as it looks odd in the generated page.

- - - - -
4551b1c9 by Guido Günther at 2024-06-13T07:44:42+02:00
fbd-feedback-led: Modernize property definitions

Adapt current phosh coding style before making other changes

- - - - -
5bd398ed by Guido Günther at 2024-06-13T15:17:51+02:00
feedback-led: Support colors as strings

The FbdDevLedColor enum defines the hardware color of the LED. We used
it for the feedbacks color value as long as the kernel mostly had
single color LEDs. As multicolor LEDs are common nowadays switch the
color to a string which will allow us to use RGB values later on.

- - - - -
4afc8398 by Guido Günther at 2024-06-13T15:17:52+02:00
feedbackd: Pass GMOBILE_USE_UNSTABLE_API to all files

No need to ack that individually

- - - - -
efd088da by Guido Günther at 2024-06-13T15:17:52+02:00
feedback-led: Document hw LED types

- - - - -
a4c35a8e by Guido Günther at 2024-06-13T15:19:03+02:00
led: Parse color values and pass them down the chain

We parse RGB color values as HEX ('#RRGGBB') and use those when a RGB
LED is available. Single color LEDs won't see a change.

- - - - -
afdeb8d5 by Guido Günther at 2024-06-13T15:19:08+02:00
theme: Use different colors for emails and calls

This makes them a bit simpler to distinguish

- - - - -
2614b6ee by Guido Günther at 2024-06-15T09:12:36+00:00
Merge branch 'rgb-color' into 'main'

Allow to set RGB colors

See merge request Librem5/feedbackd!126
- - - - -
a71fd7d4 by Guido Günther at 2024-06-15T11:14:40+02:00
manager: Move schema name to header

This makes it available to other compilation units

- - - - -
417b34be by Guido Günther at 2024-06-15T11:14:40+02:00
led: Drop FBD_FEEDBACK_LED_COLOR_LAST

With new led types we might not loop over all of them. This makes
it a bit more obvious.

- - - - -
e16dc3cd by Guido Günther at 2024-06-15T11:14:40+02:00
feedback-led: Check if at least one LED is available

So far we didn't create any FbdDevLeds if there wasn't at least one
usable LED. Once we introduce flash LEDs we might probe the LED but the
LED might not be usable as the user hasn't enabled using it. Prepare for
that scenario.

- - - - -
e47ce8e0 by Guido Günther at 2024-06-15T11:14:40+02:00
led: Add flash LED type

Camera flashes are also exported via the LED subsystem. We use a
separate LED type so they're not picked by default.

We don't use them as fallbacks either.

- - - - -
ffd939c5 by Guido Günther at 2024-06-15T11:14:40+02:00
leds: Probe flash LED

- - - - -
8f67dbd1 by Guido Günther at 2024-06-15T11:14:40+02:00
feedback-led: Allow to prefer flash LEDs over notification LEDs

- - - - -
6622444c by Guido Günther at 2024-06-15T11:14:40+02:00
udev: Allow to use flash devices

- - - - -
6aeeef15 by Guido Günther at 2024-06-21T07:29:32+00:00
Merge branch 'flash' into 'main'

led: Allow to use camera flash as status LED

See merge request Librem5/feedbackd!129
- - - - -
bdcbb08c by Guido Günther at 2024-06-21T09:50:37+02:00
packaging: Don't require root for building

This helps the nightly builds

- - - - -
946611ea by Guido Günther at 2024-06-21T07:51:30+00:00
Merge branch 'rules-requires-root' into 'main'

packaging: Don't require root for building

See merge request Librem5/feedbackd!131
- - - - -
62c92b0b by Guido Günther at 2024-06-21T08:05:51+00:00
packaging: Build-depend on shared gmobile

This ensures we don't use the subproject in packaging builds

- - - - -
6b3c43e2 by Guido Günther at 2024-06-21T08:41:40+00:00
Merge branch 'shared-gmobile' into 'main'

packaging: Build-depend on shared gmobile

See merge request Librem5/feedbackd!132
- - - - -
e2c9b530 by Guido Günther at 2024-06-21T09:25:55+00:00
cli: Reindent

Gbp-Dch: Ignore

- - - - -
212682fb by Guido Günther at 2024-06-21T09:25:55+00:00
cli: Inform user when no feedback was found

This might either be because the event doesn't exist or when the profile
doesn't have any feedback on the current level.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/76

- - - - -
6cc47e31 by Guido Günther at 2024-06-21T09:39:21+00:00
Merge branch 'no-fb' into 'main'

cli: Inform user when no feedback was found

Closes #76

See merge request Librem5/feedbackd!130
- - - - -
2b6a9508 by Guido Günther at 2024-06-21T19:57:29+00:00
feedback-theme: Fix indent

Gbp-Dch: Ignore

- - - - -
924320bb by Guido Günther at 2024-06-21T19:57:29+00:00
fbd-event: Fix some indent

Gbp-Dch: Ignore

- - - - -
e7c370a5 by Guido Günther at 2024-06-21T19:57:29+00:00
tests/fbd-event: Check if objects are finalized

This gives us more info than just using automatic cleanup

- - - - -
0a16ebe4 by Guido Günther at 2024-06-21T19:57:29+00:00
event: Make removing feedbacks more self contained

If the feedback is in our list of feedbacks disconnect signals
and drop the reference we hold.

As we have removed the signal handler that would invoke `check_ended()`
we invoke this manually when the list becomes empty.

- - - - -
3c022591 by Guido Günther at 2024-06-21T19:57:29+00:00
event: Allow to end events by level

The level here is an abstract value but in fact matches the profile
level. Well make this a property when fixing #35.

- - - - -
929d41b7 by Guido Günther at 2024-06-21T19:57:29+00:00
feedback-manager: End too noisy feedbacks on profile level change

When the profile gets lowered from e.g. quiet to silent we want to end
all ongoing feedbacks that belong to the quiet level.

This allows to e.g. silence an incoming phone call by switching the
feedback level via phosh's quick setting.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/13
Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/55

- - - - -
ed2599c9 by Guido Günther at 2024-06-21T20:09:42+00:00
Merge branch 'end-feedback' into 'main'

feedback-manager: End too noisy feedbacks on profile level change

Closes #13, #55, and #35

See merge request Librem5/feedbackd!128
- - - - -
ff26417d by Guido Günther at 2024-06-21T22:18:23+02:00
treewide: Document changes and release 0.4.0

- - - - -
09396c7d by Guido Günther at 2024-06-23T07:01:00+00:00
Merge branch 'rel-0.4.0' into 'main'

treewide: Document changes and release 0.4.0

See merge request Librem5/feedbackd!125
- - - - -
ce149e7f by Guido Günther at 2024-06-23T09:14:15+02:00
New upstream version 0.4.0
- - - - -
2f8edf98 by Guido Günther at 2024-06-23T09:14:23+02:00
Update upstream source from tag 'upstream/0.4.0'

Update to upstream version '0.4.0'
with Debian dir 2fbcce5df057e40a4cb09b40e9c888893d6606a2
- - - - -
835f530e by Guido Günther at 2024-06-23T09:14:23+02:00
New upstream release

- - - - -
a97cdf01 by Guido Günther at 2024-06-23T09:21:51+02:00
d/control: Build-depend on umockdev

Needed for the tests

- - - - -
dedad54b by Guido Günther at 2024-06-23T10:32:22+02:00
Document changes and release 0.4.0-1

- - - - -
f0cc1802 by Guido Günther at 2024-06-23T11:11:13+02:00
d/control: Add breaks on older calls

We need a calls with https://gitlab.gnome.org/GNOME/calls/-/merge_requests/734

- - - - -


30 changed files:

- .gitlab-ci.yml
- + .gitlab-ci/check-po
- .gitlab-ci/check-style.py
- + .gitlab-ci/commit-rules.yml
- .gitlab-ci/uncrustify.cfg
- NEWS
- README.md
- cli/fbcli.c
- data/default.json
- data/org.sigxcpu.feedbackd.gschema.xml
- debian/changelog
- debian/control
- doc/feedback-themes.rst
- libfeedback/lfb-event.c
- meson.build
- + src/fbd-dev-led-flash.c
- + src/fbd-dev-led-flash.h
- src/fbd-dev-led-multicolor.c
- src/fbd-dev-led-priv.h
- + src/fbd-dev-led-qcom-multicolor.c
- + src/fbd-dev-led-qcom-multicolor.h
- + src/fbd-dev-led-qcom-priv.h
- + src/fbd-dev-led-qcom.c
- + src/fbd-dev-led-qcom.h
- src/fbd-dev-led.c
- src/fbd-dev-led.h
- src/fbd-dev-leds.c
- src/fbd-dev-leds.h
- src/fbd-event.c
- src/fbd-event.h


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/feedbackd/-/compare/23f77dfb40598467e5d7b98e4917b9f31b101aea...f0cc1802e105c265f76a4d19d0c502f193006a74

-- 
This project does not include diff previews in email notifications.
View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/feedbackd/-/compare/23f77dfb40598467e5d7b98e4917b9f31b101aea...f0cc1802e105c265f76a4d19d0c502f193006a74
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20240623/b7d46cdc/attachment-0001.htm>


More information about the Debian-on-mobile-maintainers mailing list