[Debian-on-mobile-maintainers] Bug#1110197: modemmanager: Fibocom FM350-GL unusable in modemmanager 1.24.0-1

[Nikola Ilo]

Package: modemmanager
Version: 1.24.0-1
Severity: important
Tags: patch upstream fixed-upstream
X-Debbugs-Cc: nikola.ilo at gmail.com

Dear Maintainer,


Fibocom FM350-GL is not usable after upgrading to trixie modemmanager
1.24.0-1 due to the following bug which is fixed in 1.24.2 upstream.

This is a regression, the modem was working in bookworm.

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/975


The error message is as follows:

Jul 31 17:20:20 elitebook ModemManager[1521]: Bail out! ERROR:../src/plugins/fibocom/mm-shared-fibocom.c:78:get_private: assertion failed: (MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface)


The upstream patch commit can be found here:

https://gitlab.freedesktop.org/dcbw/ModemManager/-/commit/046b79a6766b6384db9cd56a9af5d148787bafe4?view=inline

diff --git a/src/plugins/fibocom/mm-shared-fibocom.c b/src/plugins/fibocom/mm-shared-fibocom.c
index 89be09efbc244a707e7fc5b7b30756650653fdcd..0fbc9b5995609ce839f653cf124013a072b93f8d 100644
--- a/src/plugins/fibocom/mm-shared-fibocom.c
+++ b/src/plugins/fibocom/mm-shared-fibocom.c
@@ -75,8 +75,8 @@ get_private (MMSharedFibocom *self)
         priv->class_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_class (self);

         /* Setup firmware interface of parent class */
-        g_assert (MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface);
-        priv->iface_modem_firmware_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface (self);
+        if (MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface)
+            priv->iface_modem_firmware_parent = MM_SHARED_FIBOCOM_GET_IFACE (self)->peek_parent_firmware_interface (self);

         g_object_set_qdata_full (G_OBJECT (self), private_quark, priv, (GDestroyNotify)private_free);
     }




Fibocom FM350-GL has a quite wide user base because it is shipped
with HP elitebooks and Lenovo thinkpads and according to the patched
file name the same issue may affect further models.

Installing the currently experimental 1.25.0 fixes the issue in trixie.


Please consider upgrading the modemmanager package to 1.24.2 or cherry picking the
patch.


-- System Information:
Debian Release: 13.0
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12.35+deb13-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages modemmanager depends on:
ii  libc6                  2.41-11
ii  libglib2.0-0t64        2.84.3-1
ii  libgudev-1.0-0         238-6
ii  libmbim-glib4          1.32.0-1
ii  libmbim-proxy          1.32.0-1
ii  libmm-glib0            1.24.0-1
ii  libpolkit-gobject-1-0  126-2
ii  libqmi-glib5           1.36.0-1
ii  libqmi-proxy           1.36.0-1
ii  libqrtr-glib0          1.2.2-1+b2
ii  libsystemd0            257.7-1
ii  polkitd                126-2

Versions of packages modemmanager recommends:
ii  libmbim-utils   1.32.0-1
ii  libqmi-utils    1.36.0-1
ii  usb-modeswitch  2.6.1-4+b2

modemmanager suggests no packages.

-- no debconf information