[Debian-on-mobile-maintainers] [Git][DebianOnMobile-team/feedbackd][upstream/latest] 46 commits: feedback-led: Ensure flash LED is stopped when prefer-flash gets disabled

Guido Günther (@agx) gitlab at salsa.debian.org
Fri Mar 21 19:29:06 GMT 2025



Guido Günther pushed to branch upstream/latest at Debian On Mobile / feedbackd


Commits:
21f9176e by Sam Day at 2025-02-07T22:51:09+01:00
feedback-led: Ensure flash LED is stopped when prefer-flash gets disabled

Fixes: #82

Signed-off-by: Sam Day <me at samcday.com>

- - - - -
d36ac316 by Guido Günther at 2025-02-14T17:25:55+00:00
Merge branch 'stop-flash-led' into 'main'

feedback-led: Ensure flash LED is stopped when prefer-flash is false

Closes #82

See merge request Librem5/feedbackd!153
- - - - -
73d5a02b by Guido Günther at 2025-03-05T11:30:50+00:00
libfeedback: Make libfeedback.h only include other files

Move the init functions to their own header so we don't clutter
libfeedback.h more in the future.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
fe17c6d5 by Guido Günther at 2025-03-05T11:30:50+00:00
ci: Update shared scripts and dot files to 0ed15ed

- - - - -
99cc84c6 by Guido Günther at 2025-03-05T11:30:50+00:00
build: Format meson files

This will make adding future files less noisy.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
2bd2f549 by Guido Günther at 2025-03-05T11:30:50+00:00
ci: Check meson file formats

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
cae5aba0 by Guido Günther at 2025-03-05T11:30:50+00:00
build: Make doc warnings fatal

This restructure showed that we introduce them just so easily

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
d974deb6 by Guido Günther at 2025-03-05T11:30:50+00:00
ci: Add consistency check

Simplifies releases

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
521de770 by Guido Günther at 2025-03-05T11:30:50+00:00
doc: Make mardown lint happy

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
47772ce2 by Guido Günther at 2025-03-05T11:30:50+00:00
README: Add getting in touch section

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
b5b16c09 by Guido Günther at 2025-03-05T11:30:50+00:00
ci: Make yamllint happy

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
a1d39e54 by Guido Günther at 2025-03-05T11:40:25+00:00
Merge branch 'format-meson' into 'main'

Split out libfeedback.h and check more things in CI

See merge request Librem5/feedbackd!158
- - - - -
836fbe09 by Guido Günther at 2025-03-06T10:57:37+01:00
treewide: Fix typos

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
70fd0a87 by Guido Günther at 2025-03-06T10:57:37+01:00
data/haptic: Document duration unit in the protocol

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
88dd6041 by Guido Günther at 2025-03-06T10:57:37+01:00
vibra-pattern: Reset pos when done

This allows to reuse the feedback.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
e92df04e by Guido Günther at 2025-03-06T10:57:37+01:00
vibra-pattern: Check for NULL dev

When running e.g. in the theme validator we might not have a vibra dev.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
54060b4e by Guido Günther at 2025-03-06T10:57:37+01:00
vibra-pattern: End pending vibra when a new one is triggered

This wasn't much of an issue for the DBus API but when using
it as event feedback it matters as we might start the new
feedback just before the old one ended due to timers being
slighlty late.

- - - - -
7b19feb2 by Guido Günther at 2025-03-06T11:00:04+01:00
fbd-feedback-vibra-pattern: Deserialize properties

This allows us to use them in feedback themes

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
85c4545a by Guido Günther at 2025-03-06T11:00:05+01:00
doc: Document the `VibraPattern` feedback

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
f681949f by Guido Günther at 2025-03-08T21:14:13+00:00
Merge branch 'vibra-pattern-theme' into 'main'

fbd-feedback-vibra-pattern: Deserialize properties

See merge request Librem5/feedbackd!155
- - - - -
8e4f1575 by Guido Günther at 2025-03-08T22:14:54+01:00
data: Refresh schema when it changed

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
bb1b5d0e by Guido Günther at 2025-03-09T12:28:08+01:00
feedback-vibra: Add and track max-haptic-strength gsetting

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
cc02a4d4 by Guido Günther at 2025-03-09T12:28:08+01:00
vibra-pattern: Honor max haptic strength

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
6d6cd905 by Guido Günther at 2025-03-09T12:28:08+01:00
vibra-rumble: Honor max haptic strength

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
41c15217 by Guido Günther at 2025-03-09T12:28:08+01:00
vibra-periodic: Honor max strength

Since we scale down the magnitude we also scale down the fade in level
to keep the ratio between the two the same.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/84

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
63b08d44 by Guido Günther at 2025-03-11T15:03:31+00:00
Merge branch 'haptic-motor-strength' into 'main'

haptic: Honor maximum strength gsetting

Closes #84

See merge request Librem5/feedbackd!156
- - - - -
d5ad81ca by Evangelos Ribeiro Tzaras at 2025-03-16T09:33:45+01:00
tests: Depend on daemon for integration test

The carefree developer might try running meson test
before meson compile, leaving them with a failing integration test:

Start of lfb-integration tests
dbus-daemon[326641]: [session uid=1000 pid=326641 pidfd=8] Activating service name='org.sigxcpu.Feedback' requested by ':1.0' (uid=1000 pid=326640 comm="$(pwd)/_build/tests/te")
+ exec $(pwd)/_build/src/feedbackd
$(pwd)/_build/run: 18: exec: $(pwd)/_build/src/feedbackd: not found

Signed-off-by: Evangelos Ribeiro Tzaras <devrtz at fortysixandtwo.eu>

- - - - -
9dd6174e by Evangelos Ribeiro Tzaras at 2025-03-16T09:33:45+01:00
tests: Depend on compiled schemas

The carefree developer might try running meson test
before meson compile, leaving them with failing
feedback-vibra and feedback-profile tests:

Start of feedbackd tests
Start of fbd tests
Start of feedback-vibra tests
fbd-feedback-manager-DEBUG: No vibra capable device found
fbd-feedback-manager-DEBUG: Failed to init leds device: No usable LEDs found
not ok /feedbackd/fbd/feedback-vibra/pattern - GLib-GIO-FATAL-ERROR: No GSettings schemas are installed on the system
Bail out!

Signed-off-by: Evangelos Ribeiro Tzaras <devrtz at fortysixandtwo.eu>

- - - - -
eda028e1 by Guido Günther at 2025-03-16T09:29:02+00:00
Merge branch 'integration_test_depend_on_daemon' into 'main'

tests: Depend on daemon for integration test

See merge request Librem5/feedbackd!159
- - - - -
5da0e4ff by Guido Günther at 2025-03-16T09:29:58+00:00
data: Add an event for notification-new-generic

We didn't do so until now to not make people go crazy with buzzing
phones. Now that we can fine tune the feedback strength better lets see
how this works.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
24aafefd by Guido Günther at 2025-03-16T09:29:58+00:00
data: Make button press feedback less intrusive

This way it can be kept enabled in more situations.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
69c4ee33 by Guido Günther at 2025-03-16T10:01:19+00:00
Merge branch 'noti-feedback' into 'main'

data: Add an event for notification-new-generic

See merge request Librem5/feedbackd!160
- - - - -
f089ad2f by Guido Günther at 2025-03-20T07:48:42+00:00
vibra-rumble: Add magnitude property

We add a magnitude property and set it to 0.5 by default. This ensure
the relative magnitude stays the same when switching from 0xFFFF to
0x7FFF in dev-vibra.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
7b026b40 by Guido Günther at 2025-03-20T07:48:42+00:00
dev-vibra: Allow full magnitude in rumble

Lets not artificially cap the magnitude in the device specific
implementation.

Since the default magnitude for the common rumble feedback was set to
0.5 in the previous commit the effective magnitude in existing themes
remains unchanged for that event.

The pattern feedbacks didn't make it into a release yet so there's
nothing that could get broken.

The change doubles the effective when using the Vibra DBus API but as it
seems that libmanette didn't land support yet lets just ignore that
here.

Periodic feedback is unaffected as it uses a different internal API.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
ac2f0d33 by Guido Günther at 2025-03-20T08:32:10+00:00
Merge branch 'magnitude-range' into 'main'

dev-vibra: Allow full magnitude in rumble

See merge request Librem5/feedbackd!161
- - - - -
cf0a420c by Guido Günther at 2025-03-21T12:14:55+01:00
doc: Mention theme reload on SIGHUP

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
f94de01a by Guido Günther at 2025-03-21T12:14:55+01:00
vibra-periodic: Modernize doc comment and property definitions

Also untabify. No functional change.

Gpb-Dch: Ignore
Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
89b33dcb by Guido Günther at 2025-03-21T12:14:55+01:00
vibra-periodic: Use same range as in rumble and periodic

We use [0.0, 1.0] in the other haptic feedbacks so let's make periodic
do the same.

We adjust dev-vibra to match that.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/86
Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
91c34f40 by Guido Günther at 2025-03-21T12:14:55+01:00
vibra-periodic: Use better defaults for fade-in-*

Lets start at zero when not specified otherwise and also set an
arbitrary fade-in-time as setting it to the duration isn't very helpful.

While at that move the defaults to the feedback rather than the device
so we ensure consistency over different device implementations.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
da93a16c by Guido Günther at 2025-03-21T12:15:56+01:00
vibra-periodic: Deserialize magnitude and fade-in-level manually

This allows us to add proper fallbacks

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
c37bfecb by Guido Günther at 2025-03-21T12:15:57+01:00
vibra-periodic: Add a fallback for the previous [0, 0xFFFF] range

This keeps old themes working

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
3d062c09 by Guido Günther at 2025-03-21T12:15:57+01:00
default/theme: Use [0.0, 1.0] for vibra-periodic

We switch `message-new-cellbroadcast` to VibraPeriodic as that is better
recognizable than the periodic pattern.

Signed-off-by: Guido Günther <agx at sigxcpu.org>

- - - - -
f2fde30f by Guido Günther at 2025-03-21T18:15:30+00:00
Merge branch 'periodic-magnitude' into 'main'

Use [0.0, 0.1] for periodic pattern too

Closes #86 and #84

See merge request Librem5/feedbackd!162
- - - - -
98f2c6a0 by Guido Günther at 2025-03-21T19:20:56+01:00
treewide: Document changes and release 0.8.0

- - - - -
a0295286 by Guido Günther at 2025-03-21T18:59:36+00:00
Merge branch 'rel-0.8.0' into 'main'

treewide: Document changes and release 0.8.0

See merge request Librem5/feedbackd!163
- - - - -
4e4b31a7 by Guido Günther at 2025-03-21T20:09:06+01:00
New upstream version 0.8.0
- - - - -


40 changed files:

- .dir-locals.el
- .editorconfig
- .gitlab-ci.yml
- + .gitlab-ci/check-consistency
- + .gitlab-ci/check-meson
- .gitlab-ci/check-po
- .gitlab-ci/uncrustify.cfg
- NEWS
- README.md
- cli/meson.build
- data/default.json
- data/meson.build
- data/org.sigxcpu.Feedback.Haptic.xml
- data/org.sigxcpu.feedbackd.gschema.xml
- debian/changelog
- doc/Feedback-theme-spec-0.0.0.md
- doc/feedback-themes.rst
- doc/feedbackd.rst
- doc/initialization.md
- doc/meson.build
- libfeedback/libfeedback.c → libfeedback/lfb-main.c
- + libfeedback/lfb-main.h
- libfeedback/libfeedback.h
- libfeedback/meson.build
- meson.build
- src/fbd-dev-led-multicolor.c
- src/fbd-dev-vibra.c
- src/fbd-dev-vibra.h
- src/fbd-feedback-led.c
- src/fbd-feedback-profile.c
- src/fbd-feedback-vibra-pattern.c
- src/fbd-feedback-vibra-periodic.c
- src/fbd-feedback-vibra-priv.h
- src/fbd-feedback-vibra-rumble.c
- src/fbd-feedback-vibra.c
- src/fbd-haptic-manager.c
- src/meson.build
- tests/meson.build
- tests/services/meson.build
- + tests/test-fbd-feedback-vibra.c


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/feedbackd/-/compare/459ef89eef82014bbca091b745bcae1e28f6ce60...4e4b31a7617868e127019da2f5af2fdf361e45f1

-- 
View it on GitLab: https://salsa.debian.org/DebianOnMobile-team/feedbackd/-/compare/459ef89eef82014bbca091b745bcae1e28f6ce60...4e4b31a7617868e127019da2f5af2fdf361e45f1
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/debian-on-mobile-maintainers/attachments/20250321/149aadb8/attachment-0001.htm>


More information about the Debian-on-mobile-maintainers mailing list