[Debian-pan-maintainers] Bug#1078987: cbflib: FTBFS against HDF5 1.14 - Needs -DH5_USE_110_API

[Gilles Filippini]

Source: cbflib
Version: 0.9.7+dfsg1-3.1
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

The cbflib package fails to build from source in a test rebuild
against hdf5 1.14 currently in experimental:

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOU
RCE=2 -g -O3 -Wall -D_USE_XOPEN_EXTENDED -fno-strict-aliasing     -DCBF_REGEXLIB_REGEX    -fPIC -I/<<PKGBUILDDIR>>/include -I/<<PKGBUILDDIR>>/src -I/usr/include/hdf5/serial   -c /<<PKGBUILDDIR>>/src/cbf.c /<<PKG
BUILDDIR>>/src/cbf_airy_disk.c /<<PKGBUILDDIR>>/src/cbf_alloc.c /<<PKGBUILDDIR>>/src/cbf_ascii.c /<<PKGBUILDDIR>>/src/cbf_binary.c /<<PKGBUILDDIR>>/src/cbf_byte_offset.c /<<PKGBUILDDIR>>/src/cbf_canonical.c /<<P
KGBUILDDIR>>/src/cbf_codes.c /<<PKGBUILDDIR>>/src/cbf_compress.c /<<PKGBUILDDIR>>/src/cbf_context.c /<<PKGBUILDDIR>>/src/cbf_copy.c /<<PKGBUILDDIR>>/src/cbf_file.c /<<PKGBUILDDIR>>/src/cbf_getopt.c /<<PKGBUILDDI
R>>/src/cbf_hdf5.c /<<PKGBUILDDIR>>/src/cbf_hdf5_filter.c /<<PKGBUILDDIR>>/src/cbf_lex.c /<<PKGBUILDDIR>>/src/cbf_minicbf_header.c /<<PKGBUILDDIR>>/src/cbf_nibble_offset.c /<<PKGBUILDDIR>>/src/cbf_packed.c /<<PK
GBUILDDIR>>/src/cbf_predictor.c /<<PKGBUILDDIR>>/src/cbf_read_binary.c /<<PKGBUILDDIR>>/src/cbf_read_mime.c /<<PKGBUILDDIR>>/src/cbf_simple.c /<<PKGBUILDDIR>>/src/cbf_string.c /<<PKGBUILDDIR>>/src/cbf_stx.c /<<P
KGBUILDDIR>>/src/cbf_tree.c  /<<PKGBUILDDIR>>/src/cbf_uncompressed.c /<<PKGBUILDDIR>>/src/cbf_write.c /<<PKGBUILDDIR>>/src/cbf_write_binary.c /<<PKGBUILDDIR>>/src/cbf_ws.c /<<PKGBUILDDIR>>/src/cbff.c /<<PKGBUILD
DIR>>/src/md5c.c /<<PKGBUILDDIR>>/src/img.c /<<PKGBUILDDIR>>/src/fgetln.c 
/<<PKGBUILDDIR>>/src/cbf.c: In function ‘cbf_select_saveframe’:
/<<PKGBUILDDIR>>/src/cbf.c:2498:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 2498 |   if (!handle)
      |   ^~
In file included from /<<PKGBUILDDIR>>/src/cbf.c:256:
/<<PKGBUILDDIR>>/include/cbf.h:895:24: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  895 | #define cbf_failnez(f) { int err; err = (f); if (err) return err; }
      |                        ^
/<<PKGBUILDDIR>>/src/cbf.c:2505:5: note: in expansion of macro ‘cbf_failnez’
 2505 |     cbf_failnez (cbf_find_parent (&node, handle->node, CBF_DATABLOCK))
      |     ^~~~~~~~~~~
In file included from /usr/include/hdf5/serial/H5public.h:31,
                 from /usr/include/hdf5/serial/hdf5.h:21,
                 from /<<PKGBUILDDIR>>/include/cbf.h:253,
                 from /<<PKGBUILDDIR>>/src/cbf_hdf5.c:258:
/<<PKGBUILDDIR>>/src/cbf_hdf5.c: In function ‘cbf_H5Ocmp’:
/usr/include/hdf5/serial/H5version.h:921:23: error: too few arguments to function ‘H5Oget_info3’
  921 |   #define H5Oget_info H5Oget_info3
      |                       ^~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/cbf_hdf5.c:3948:27: note: in expansion of macro ‘H5Oget_info’
 3948 |             herr_t err0 = H5Oget_info(id0,&info0);
      |                           ^~~~~~~~~~~


Adding -DH5_USE_110_API to CPPFLAGS fixes the issue.

Best,
_g.


- -- System Information:
Debian Release: 12.0
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-21-amd64 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEoJObzArDE05WtIyR7+hsbH/+z4MFAmbCI5kACgkQ7+hsbH/+
z4N6mQf7BKNdfFRtLGCdEfmWqey4Bv0vJRmct07o+2BlcR7tGdzCsoBxSpEjvNLl
NjqEs0a8/3yOSSvOIvMvrzYTxJtIjBHABNVb/M3RzTpgftwc1waG7jIXUam+Xwx/
BwNS0m6UNrrSJBcbAPStH4ewRA2MxkmzP0PN5LeIfgZRr5ouOhnxwIyjOoZbY7KP
bXPdiirf1irlQbFTHXNjRsZgVMsDooCFIJufYfmwKNj2ZJF278qvS4TusijsnRsX
eY9jqijWL9sHJ39U3MJOIKyI2vvIpivfsD7E+PIJ/aFWaVRzKGXGb4nsrUVsU7iy
B2l2A1tmDNkaNU6p0fT0avIkczgnfw==
=IbXS
-----END PGP SIGNATURE-----