[Debian-pan-maintainers] Packaging pytango 9.2.0

[PICCA Frederic-Emmanuel]

Hello,

here the review for itango.

control
----------


Source: itango
Maintainer: Debian Science Maintainers <debian-science-maintainers at lists.alioth.debian.org>
Uploaders: Sandor Bodo-Merle <sbodomerle at gmail.com>
Section: science
Priority: extra
Build-Depends: debhelper (>= 9),
               dh-python,
               python-all-dev,
               python-ipython,
               python-setuptools,
               python-tango,
               python3-all-dev,
               python3-ipython,
               python3-setuptools,
               python3-tango
Standards-Version: 3.9.8
Vcs-Browser: https://anonscm.debian.org/cgit/debian-science/packages/itango.git
Vcs-Git: https://anonscm.debian.org/git/debian-science/packages/itango.git
Homepage: http://www.tango-controls.org/static/PyTango/latest/doc/html/
X-Python-Version: >= 2.6
X-Python3-Version: >= 3.2



since itango is a pure python module you can replace

python-all-dev and python3-all-dev
by
python-all and python3-all

I am not sur that the homepage is the right one.

other point, you are using sphinx in the rules file, but you do not added the python-sphinx dependency.
and also the sphinxdoc.

this package provide an itango-qt script so the 

python-qtconsole dependency should be somewhere :)

if it is compatible with all version of the Qtconsole, i would put

python-qtconsole | ipython-qtconsole in order to have something backportable (who knows)

idem for python3


Please put the documentation into an itango-doc package.



copyright
-------------

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: Tiago Coutinho
Upstream-Contact: tcoutinho at cells.es
Source: https://pypi.python.org/pypi/itango

Files: *
Copyright: © 2010-2012, CELLS / ALBA Synchrotron, Bellaterra, Spain
License: LGPL-3+

License: LGPL-3+
 Tango is free software: you can redistribute it and/or modify
 it under the terms of the GNU Lesser General Public License as published by
 the Free Software Foundation, either version 3 of the License, or
 (at your option) any later version.
 .
 Tango is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU Lesser General Public License for more details.
 .
 You should have received a copy of the GNU Lesser General Public License
 along with this package; if not, write to the Free Software
 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 .
 On Debian systems, the complete text of the GNU Lesser General
 Public License can be found in `/usr/share/common-licenses/LGPL-3'.


Can you add a section for the debian package with your copyright, with LGPL-3+.


rules
--------


#!/usr/bin/make -f

export PYBUILD_NAME=itango

%:
        dh $@ --with python2,python3 --buildsystem=pybuild

override_dh_auto_build:
        dh_auto_build
        PYTHONPATH=. http_proxy='127.0.0.1:9' sphinx-build -N -bman doc/ build/man
        cp build/man/itango.1 build/man/itango3.1

override_dh_auto_clean:
        dh_auto_clean
        rm -rf build
        rm -rf *.egg-info


You should check that it compiles with pbuilder/cowbuilder or sbuild ;)

Cheers

Fred