[Debian-salsa-ci] (no subject)

[Aurelien Jarno]

Bcc: 
Subject: Re: sqlitecpp: FTBFS with the nocheck build profile
Reply-To: 
In-Reply-To: <aNx9fO9aSWKGFMSY at nuc>

Hi Santiago,

On 2025-10-01 03:01, Santiago Vila wrote:
> tags 1116917 help
> thanks
> 
> Hello. I cloned sqlitecpp in salsa and added this salsa-ci.yml in branch wip-1:
> 
> ---
> include:
>   - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/recipes/debian.yml
> 
> variables:
>   SALSA_CI_ENABLE_BUILD_PACKAGE_PROFILES: 1
>   BUILD_PROFILES: nocheck
> 
> to reproduce this bug, but sbuild seems to be misbehaving, because
> build-depends says:
> 
> libgtest-dev <!nocheck>
> 
> but the job "test-build-profiles" is installing the package anyway,
> and the build succeeds when it should not:
> 
> https://salsa.debian.org/sanvila/sqlitecpp/-/jobs/8378983
> 
> Bug in Salsa CI? Bug in sbuild?

This looks like a bug in Salsa CI which passes the profiles directly to 
dpkg-buildpackage through the --debbuildopts sbuild option:

| BUILD_COMMAND=sbuild --dist=unstable --no-clean-source  --source --arch-all --arch-any --build-dir=/builds/sanvila/sqlitecpp/debian/output --debbuildopts=--build-profiles="nocheck" --no-run-lintian --verbose

This way sbuild is never informed of the build profile and thus just 
installs all the build-dependencies. Salsa CI should uses the --profiles
option of sbuild, which will respect the profiles during the 
build-dependencies installation and will then pass the profiles to 
dpkg-buildpackage.

Cheers
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net