Bug#535133: rasmol: basename implicitly converted to pointer

[dann frazier]

Package: rasmol
Version: 2.7.4.2-4
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

  Function `basename' implicitly converted to pointer at molecule.c:338
  Function `basename' implicitly converted to pointer at molecule.c:338
  Function `basename' implicitly converted to pointer at molecule.c:338
  Function `basename' implicitly converted to pointer at molecule.c:338

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

The attached patch assumes the GNU implementation of basename() is
desired. The same affect could be produced by adding -D_GNU_SOURCE to
the CFLAGS. If the POSIX basename semantics are preferred, you'll
probably want to #include <libgen.h> instead.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions

-- 
dann frazier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rasmol-basename.patch
Type: text/x-diff
Size: 232 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20090629/3514c3ea/attachment.patch>