Bug#584172: Disabling GetIDMapper inlining for building VISU

Andre Espaze andre.espaze at logilab.fr
Wed Jun 2 10:17:05 UTC 2010


> 
> > I have enclosed a patch tested on my machine, fell free to correct
> > it if I was wrong.
> [...]
> 
> I do not understand why you added #if tests, just adding 'template' at
> the very beginning is enough.  It was not explicit in my previous
> mail, but I tried to find an alternative solution because your's works
> only with g++, and you will need those #if tests if you want to
> forward it upstream.  OTOH mine is portable, and it could be adopted
> more easily by upstream, I guess.  Within Debian, which patch is
> checked in does not matter.
I added the #if tests because the patch is a solution to a problem
occuring only when compiling with g++ and -O2 optimizations. Would
you like upstream to force the symbol export even if the code compiles
without g++ optimizations? Did you check that the template problem occurs
for others C++ compilers before saying that you have a portable solution?

André







More information about the debian-science-maintainers mailing list